git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-rebase: reword squashes commits in case of merge-conflicts

From
Cch <cr@onlinehome.de>
Date
Jun 15, 2018, 14:35 UTC
Message-ID
<118a8026-7050-dbd2-9f46-31e8db2bac05@onlinehome.de>
In-Reply-To
<20180612100810.GA27231@sigill.intra.peff.net>
On 12.06.2018 12:08, Jeff King wrote:
 > Thanks for a thorough report. I couldn't reproduce it on v2.17.1 on
 > Linux, which makes me wonder if the issue is related to git-for-windows
 > somehow. To the best of my knowledge (and a quick scan of "git diff"
 > results) the code should be the same, though.

I gave native Git version 2.17.1 on Ubuntu 18.04 (no WSL this time) a try and was able to reproduce the issue outlined in my first email.

In case there is a misunderstanding, when I wrote
On 11.06.2018 18:06, ch wrote:
 > After the rebase the 'stuff' branch only has a single commit even though I'd
 > expect there to be two according to the instructions that were passed to
 > git-rebase.

I actually meant that there's only a single commit exclusively reachable from 'stuff' after the rebase, i.e.

   $ git log stuff ^master

only lists a single commit while there actually should be two unless I'm missing something.

Sorry for being a bit sloppy in my initial report.
- ch
Previous: Jeff KingNext: Elijah Newren
Message 3 of 19 in “[BUG] git-rebase: reword squashes commits in case of merge-conflicts”
  1. chJun 11, 2018
  2. Jeff KingJun 12, 2018
  3. chJun 15, 2018
  4. Elijah NewrenJun 16, 2018
  5. Eric SunshineJun 17, 2018
  6. sequencer: do not squash 'reword' commits when we hit conflictsElijah Newren, Jun 17, 2018
  7. Phillip WoodJun 17, 2018
  8. Johannes SchindelinJun 17, 2018
  9. Phillip WoodJun 18, 2018
  10. Junio C HamanoJun 18, 2018
  11. Johannes SchindelinJun 18, 2018
  12. Phillip WoodJun 19, 2018
  13. sequencer: do not squash 'reword' commits when we hit conflictsPhillip Wood, Jun 19, 2018
  14. Elijah NewrenJun 19, 2018
  15. Junio C HamanoJun 19, 2018
  16. t/lib-rebase.sh: support explicit 'pick' commands in 'fake_editor.sh'SZEDER Gábor, Aug 23, 2018
  17. Junio C HamanoAug 23, 2018
  18. Johannes SchindelinAug 23, 2018
  19. Johannes SchindelinJun 17, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.