git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitk: Fix restoring of pane sizes

From
Sergey Vlasov <vsu@altlinux.ru>
Date
Feb 11, 2007, 16:58 UTC
Message-ID
<117121311393-git-send-email-vsu@altlinux.ru>
In-Reply-To
<20070211195643.b1f548f2.vsu@altlinux.ru>

At least on Linux with Tk 8.4.13 gitk always came up with default pane sizes, even though they were previously saved in ~/.gitk. Apparently setting width and height of frames in these panes when creating them is not enough, and an explicit paneconfigure call is needed.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
---
 gitk |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index df1ce8c..7e6ee56 100755
--- a/gitk
+++ b/gitk
@@ -577,6 +577,7 @@ proc makewindow {} {
     pack .tf.bar -in .tf -side bottom -fill x
     pack .tf.histframe -fill both -side top -expand 1
     .ctop add .tf
+    .ctop paneconfigure .tf -height $geometry(topheight)
 
     # now build up the bottom
     panedwindow .pwbottom -orient horizontal
@@ -638,6 +639,7 @@ proc makewindow {} {
     $ctext tag conf found -back yellow
 
     .pwbottom add .bleft
+    .pwbottom paneconfigure .bleft -width $geometry(botwidth)
 
     # lower right
     frame .bright
-- 
1.5.0.rc4.50.g403de
Previous: Sergey VlasovNext: Sergey Vlasov
Message 5 of 8 in “Make gitk save and restore the user set window position.”
  1. Make gitk save and restore the user set window position.Mark Levedahl, Feb 11, 2007
  2. Make gitk save and restore the user set window position.Mark Levedahl, Feb 11, 2007
  3. Clean up geometry save code in gitk.Mark Levedahl, Feb 11, 2007
  4. Sergey VlasovFeb 11, 2007
  5. gitk: Fix restoring of pane sizesSergey Vlasov, Feb 11, 2007
  6. gitk: Fix restoring of column widths in the commit treeSergey Vlasov, Feb 11, 2007
  7. Mark LevedahlFeb 11, 2007
  8. Junio C HamanoFeb 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.