git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Clean up geometry save code in gitk.

From
Mark Levedahl <mdl123@verizon.net>
Date
Feb 11, 2007, 14:27 UTC
Message-ID
<1171204040779-git-send-email-mdl123@verizon.net>
In-Reply-To
<11712040403973-git-send-email-mdl123@verizon.net>

Leftover code was subtracting zero from several items before storing, an obvious noop now deleted.

Signed-off-by: Mark Levedahl <mdl123@verizon.net>
---
 gitk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gitk b/gitk
index 23bf567..df1ce8c 100755
--- a/gitk
+++ b/gitk
@@ -832,9 +832,9 @@ proc savestuff {w} {
 	puts $f "set geometry(main) [wm geometry .]"
 	puts $f "set geometry(topwidth) [winfo width .tf]"
 	puts $f "set geometry(topheight) [winfo height .tf]"
-	puts $f "set geometry(canv) [expr {[winfo width $canv]-0}]"
-	puts $f "set geometry(canv2) [expr {[winfo width $canv2]-0}]"
-	puts $f "set geometry(canv3) [expr {[winfo width $canv3]-0}]"
+	puts $f "set geometry(canv) [winfo width $canv]"
+	puts $f "set geometry(canv2) [winfo width $canv2]"
+	puts $f "set geometry(canv3) [winfo width $canv3]"
 	puts $f "set geometry(botwidth) [winfo width .bleft]"
 	puts $f "set geometry(botheight) [winfo height .bleft]"
 
-- 
1.5.0.rc3.24.g0c5e
Previous: Mark LevedahlNext: Sergey Vlasov
Message 3 of 8 in “Make gitk save and restore the user set window position.”
  1. Make gitk save and restore the user set window position.Mark Levedahl, Feb 11, 2007
  2. Make gitk save and restore the user set window position.Mark Levedahl, Feb 11, 2007
  3. Clean up geometry save code in gitk.Mark Levedahl, Feb 11, 2007
  4. Sergey VlasovFeb 11, 2007
  5. gitk: Fix restoring of pane sizesSergey Vlasov, Feb 11, 2007
  6. gitk: Fix restoring of column widths in the commit treeSergey Vlasov, Feb 11, 2007
  7. Mark LevedahlFeb 11, 2007
  8. Junio C HamanoFeb 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.