Re: [RFC] extending git-ls-files --exclude.

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jul 25, 2005, 20:59 UTC
Message-ID: <1122325168.6866.14.camel@localhost.localdomain>
In-Reply-To: <7vk6jelkty.fsf@assigned-by-dhcp.cox.net>

On Mon, 2005-07-25 at 12:58 -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Catalin Marinas <catalin.marinas@gmail.com> writes:
> >> An exclude pattern is of the following format:
> > [...]
> >
> > That's fine. Actually, the Porcelain would care much about it since it
> > gets the information already filtered by git.
> 
> Your saying "fine" is a relief.  This change aims at helping
> Porcelain people by making it less likely for Porcelain to need
> its own filtering. As you say, if ls-files filters more than
> the Porcelain wants, that's a bigger problem.

I don't plan to add any additional filtering in StGIT. What I meant above was that Porcelain would not care much about the patterns. The user should cope with what git provides, nothing more. With these git patches, I think there are enough features for filtering.

Show 6 quoted lines

> > Wouldn't it be clearer to have the general rules first (*.html),
> > overridden by the more specific ones (!foo.html)? Just my opinion, I
> > don't know what others think.
> 
> I do not know, either, but I do know it is consistent with the
> "first match determines fate" rule and cleaner to implement.

I also don't have a strong preference for this and the "first match" rule clarifies it (otherwise, you could have pushed them on a list in reverse order).

-- 
Catalin