git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: I made a flame graph renderer for git's trace2 output

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
May 20, 2019, 18:49 UTC
Message-ID
<0c3e48e0-ef87-39c2-a984-ba7deede0651@jeffhostetler.com>
In-Reply-To
<20190510170014.GQ14763@szeder.dev>
On 5/10/2019 1:00 PM, SZEDER Gábor wrote:
Show 14 quoted lines
> On Fri, May 10, 2019 at 12:38:52PM -0400, Derrick Stolee wrote:
>> export GIT_TR2_EVENT=~/git-tr2-event.txt
> 
> Hrm,  better late than never, or at least better late than after it's
> in a release...
> 
> Why does an environment variable that is supposed to be set by users
> have this "TR2" abbreviation in its prefix?  What exactly, if
> anything, did we gain by omitting "ACE" and not calling it
> "GIT_TRACE2_..."?
> 
> Ken Thompson springs to mind, who (allegedly?) later regretted
> spelling creat()/O_CREAT without the 'e'...
>

For closure here on this thread. I chose TR2 rather than TRACE2 somewhat at random for convenience during testing. Changing is fine as you suggest in your other patch series.

Thanks Jeff

Previous: SZEDER GáborNext: Jeff King
Message 4 of 9 in “I made a flame graph renderer for git's trace2 output”
  1. Ævar Arnfjörð BjarmasonMay 10, 2019
  2. Derrick StoleeMay 10, 2019
  3. SZEDER GáborMay 10, 2019
  4. Jeff HostetlerMay 20, 2019
  5. Jeff KingMay 10, 2019
  6. Ævar Arnfjörð BjarmasonMay 10, 2019
  7. Jeff HostetlerMay 20, 2019
  8. Ævar Arnfjörð BjarmasonMay 21, 2019
  9. Jeff HostetlerMay 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.