From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mon, 20 May 2019 18:49:26 GMT
Subject: Re: I made a flame graph renderer for git's trace2 output
Message-ID: <0c3e48e0-ef87-39c2-a984-ba7deede0651@jeffhostetler.com>
In-Reply-To: <20190510170014.GQ14763@szeder.dev>



On 5/10/2019 1:00 PM, SZEDER Gábor wrote:
> On Fri, May 10, 2019 at 12:38:52PM -0400, Derrick Stolee wrote:
>> export GIT_TR2_EVENT=~/git-tr2-event.txt
> 
> Hrm,  better late than never, or at least better late than after it's
> in a release...
> 
> Why does an environment variable that is supposed to be set by users
> have this "TR2" abbreviation in its prefix?  What exactly, if
> anything, did we gain by omitting "ACE" and not calling it
> "GIT_TRACE2_..."?
> 
> Ken Thompson springs to mind, who (allegedly?) later regretted
> spelling creat()/O_CREAT without the 'e'...
> 

For closure here on this thread.  I chose TR2 rather than TRACE2
somewhat at random for convenience during testing.  Changing is fine
as you suggest in your other patch series.

Thanks
Jeff