Re: [PATCH v2 1/3] config: create a function to format section headers
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Jun 19, 2017, 12:08 UTC
- Message-ID
- <087c8d6e-10f0-2c1f-1974-a97f4f685288@ramsayjones.plus.com>
- In-Reply-To
- <1497820591-93434-1-git-send-email-sahildua2305@gmail.com>
On 18/06/17 22:16, Sahil Dua wrote:
Show 8 quoted lines
> Factor out the logic which creates section headers in the config file, > e.g. the 'branch.foo' key will be turned into '[branch "foo"]'. > > This introduces no function changes, but is needed for a later change > which adds support for copying branch sections in the config file. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Adding my SOB isn't really appropriate here - I only made a very very minor contribution. At _most_ you might consider 'Helped-by:', but even that would probably be overkill. ;-)
Thanks.
ATB, Ramsay Jones
Show 39 quoted lines
> Signed-off-by: Sahil Dua <sahildua2305@gmail.com>
> ---
> config.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/config.c b/config.c
> index 34a139c..32fd3c8 100644
> --- a/config.c
> +++ b/config.c
> @@ -2169,10 +2169,10 @@ static int write_error(const char *filename)
> return 4;
> }
>
> -static int store_write_section(int fd, const char *key)
> +static struct strbuf store_create_section(const char *key)
> {
> const char *dot;
> - int i, success;
> + int i;
> struct strbuf sb = STRBUF_INIT;
>
> dot = memchr(key, '.', store.baselen);
> @@ -2188,6 +2188,15 @@ static int store_write_section(int fd, const char *key)
> strbuf_addf(&sb, "[%.*s]\n", store.baselen, key);
> }
>
> + return sb;
> +}
> +
> +static int store_write_section(int fd, const char *key)
> +{
> + int success;
> +
> + struct strbuf sb = store_create_section(key);
> +
> success = write_in_full(fd, sb.buf, sb.len) == sb.len;
> strbuf_release(&sb);
>
>