git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 09/13] rev-list: add object filtering support

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Sep 27, 2017, 17:26 UTC
Message-ID
<0373bf21-af3c-0ab6-9fba-8559ba05ebb7@jeffhostetler.com>
In-Reply-To
<20170926154457.51f4da732122f00381d646e1@google.com>
On 9/26/2017 6:44 PM, Jonathan Tan wrote:
Show 8 quoted lines
> On Fri, 22 Sep 2017 20:30:13 +0000
> Jeff Hostetler <git@jeffhostetler.com> wrote:
> 
>> +		if (filter_options.relax) {
> 
> Add some documentation about how this differs from ignore_missing_links
> in struct rev_info.
>

It's unclear what that field means. (It's not documented that I saw.) And it is explicitly turned on and off in pack-bitmap.c, so again I'm not sure how that agrees with what I'm doing.

My relax field is probably an interim thing (to allow rev-list, index-pack, and friends not complain about missing objects during my development).

I suspect that you and I will need to merge our efforts here. You have a similar variable "revs->exclude_promisor_objects". But I need to study how our usages differ.

Thanks, Jeff

Previous: Jonathan TanNext: Jeff Hostetler
Message 12 of 16 in “list-objects-filter-large: add large blob filter to list-objects”
  1. 05/13 list-objects-filter-large: add large blob filter to list-objectsJeff Hostetler, Sep 22, 2017
  2. 06/13 list-objects-filter-sparse: add sparse-checkout based filterJeff Hostetler, Sep 22, 2017
  3. 07/13 object-filter: common declarations for object filteringJeff Hostetler, Sep 22, 2017
  4. Jonathan TanSep 26, 2017
  5. Jeff HostetlerSep 27, 2017
  6. Jonathan TanSep 28, 2017
  7. Jeff HostetlerSep 28, 2017
  8. Jonathan TanSep 29, 2017
  9. 08/13 list-objects: add traverse_commit_list_filtered methodJeff Hostetler, Sep 22, 2017
  10. 09/13 rev-list: add object filtering supportJeff Hostetler, Sep 22, 2017
  11. Jonathan TanSep 26, 2017
  12. Jeff HostetlerSep 27, 2017
  13. 10/13 rev-list: add filtering help textJeff Hostetler, Sep 22, 2017
  14. 11/13 t6112: rev-list object filtering testJeff Hostetler, Sep 22, 2017
  15. 13/13 pack-objects: add filtering help textJeff Hostetler, Sep 22, 2017
  16. 12/13 pack-objects: add object filtering supportJeff Hostetler, Sep 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.