From: Jeff Hostetler <git@jeffhostetler.com>
Date: Wed, 27 Sep 2017 17:26:16 GMT
Subject: Re: [PATCH 09/13] rev-list: add object filtering support
Message-ID: <0373bf21-af3c-0ab6-9fba-8559ba05ebb7@jeffhostetler.com>
In-Reply-To: <20170926154457.51f4da732122f00381d646e1@google.com>



On 9/26/2017 6:44 PM, Jonathan Tan wrote:
> On Fri, 22 Sep 2017 20:30:13 +0000
> Jeff Hostetler <git@jeffhostetler.com> wrote:
> 
>> +		if (filter_options.relax) {
> 
> Add some documentation about how this differs from ignore_missing_links
> in struct rev_info.
> 

It's unclear what that field means.  (It's not documented that I saw.)
And it is explicitly turned on and off in pack-bitmap.c, so again I'm
not sure how that agrees with what I'm doing.

My relax field is probably an interim thing (to allow rev-list, index-pack,
and friends not complain about missing objects during my development).

I suspect that you and I will need to merge our efforts here.  You have
a similar variable "revs->exclude_promisor_objects".  But I need to study
how our usages differ.

Thanks,
Jeff