git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] interpret-trailers: add options for actions

From
Paolo Bonzini <bonzini@gnu.org>
Date
Jul 12, 2017, 21:33 UTC
Message-ID
<02354996-dccc-b2fb-a3b5-aa819229caa0@gnu.org>
In-Reply-To
<20170712141028.2d6beecc@twelve2.svl.corp.google.com>
On 12/07/2017 23:10, Jonathan Tan wrote:
> When I would expect the last 2 commands to produce the same output. Maybe
> invoke set_where(where, NULL) when "unset" is true? And change set_where()
> accordingly. Same for the other two option parsing functions.
Sounds good, and I'll also add a test case of course.

In fact arg is already NULL if unset is true, so the code of the three option parsing functions becomes simpler.

Thanks!
Paolo
Previous: Jonathan TanNext: Christian Couder
Message 8 of 10 in “interpret-trailers: add --where, --if-exists, --if-missing”
  1. 0/3 interpret-trailers: add --where, --if-exists, --if-missingPaolo Bonzini, Jul 12, 2017
  2. 1/3 trailers: create struct trailer_optsPaolo Bonzini, Jul 12, 2017
  3. Jonathan TanJul 12, 2017
  4. 2/3 trailers: export action enums and corresponding lookup functionsPaolo Bonzini, Jul 12, 2017
  5. Jonathan TanJul 12, 2017
  6. 3/3 interpret-trailers: add options for actionsPaolo Bonzini, Jul 12, 2017
  7. Jonathan TanJul 12, 2017
  8. Paolo BonziniJul 12, 2017
  9. Christian CouderJul 12, 2017
  10. Paolo BonziniJul 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.