From: Paolo Bonzini <bonzini@gnu.org>
Date: Wed, 12 Jul 2017 21:33:59 GMT
Subject: Re: [PATCH 3/3] interpret-trailers: add options for actions
Message-ID: <02354996-dccc-b2fb-a3b5-aa819229caa0@gnu.org>
In-Reply-To: <20170712141028.2d6beecc@twelve2.svl.corp.google.com>

On 12/07/2017 23:10, Jonathan Tan wrote:
> When I would expect the last 2 commands to produce the same output. Maybe
> invoke set_where(where, NULL) when "unset" is true? And change set_where()
> accordingly. Same for the other two option parsing functions.

Sounds good, and I'll also add a test case of course.

In fact arg is already NULL if unset is true, so the code of the three
option parsing functions becomes simpler.

Thanks!

Paolo