Re: [PATCH] Revert "Declare both git-switch and git-restore experimental"

From: Matthieu Baerts <matttbe@kernel.org>
Date: Feb 20, 2024, 18:39 UTC
Message-ID: <0174d19e-abc4-4d2e-a60d-e7df52b74d0b@kernel.org>
In-Reply-To: <xmqqzfvvovva.fsf@gitster.g>

Hi Junio,

Thank you for your reply!

On 20/02/2024 7:04 pm, Junio C Hamano wrote:

Show 12 quoted lines

> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> 
>> The only reason why I ask is because I was vaguely aware of some
>> discussions (don’t know how long ago) where someone was skeptical about
>> changing one of the two experimental commands, and then someone else in
>> turn expressed some frustration about this concern since they are after
>> all marked experimental. And the context was some UI/UX problems with
>> the command.
> 
> There was a discussion to further make "switch" deviate from
> "checkout" by taking advantage of its experimental status [*1*], for
> example.

I appreciate the references, thank you! It is interesting to note changes have been proposed a few years ago, but none have been applied.

Show 5 quoted lines

> Being marked as "EXPERIMENTAL" allows us to redefine the behaviour
> in a way that would break existing users, like changing what the
> "-c" option means completely (so that folks who are used to say
> "switch -c blah" will be surprised next time they type that command,
> but they cannot complain).

Personally, I think I would complain, and go back to git-checkout :-)

> Once you remove the label, you no longer
> have such a freedom to even imagine departing from the existing
> behaviour (I wrote essentially the same thing before [*2*]).  Are we
> ready to paint us into such a corner yet?

I'm not involved in this project, but I think after a few versions / years, it is hard to still keep this experimental status. I understand it is tempting to keep it, but I think it is now too late. Despite the now old label, you probably already no longer have such freedom to radically change their behaviours, no?

> Is "switch/restore" perfect
> and do not need departing changes anymore?

To me, they don't need departing changes. If they are still experimental after 5 years, it is hard to recommend them :)

Cheers, Matt

-- 
Sponsored by the NGI0 Core fund.