git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [Test Breakage 2.46.0-rc0] Test t0021.35 fails on NonStop

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Jul 15, 2024, 17:39 UTC
Message-ID
<00c001dad6dd$f336c3e0$d9a44ba0$@nexbridge.com>
In-Reply-To
<xmqqh6cq4ngc.fsf@gitster.g>
On Monday, July 15, 2024 12:42 PM, Junio C Hamano wrote:
><rsbecker@nexbridge.com> writes:
>
>> What is strange is that when running on NonStop using ksh, t0000.1 has
>> never failed. I think the situation is subtly different from what we are
solving.
Show 6 quoted lines
>> My take is that there is a difference in the local vs. non-local
>> variable set semantic, rather than just accepting the keyword. I would
>> propose that we need a more comprehensive local test to verify the
>> actual expected semantics rather than just testing the syntax.
>
>It is possible that I may be misreading that first test, but as far as I
can tell, it is
>testing not just the syntax but tests how the variables declared "local"
behaves and
>should notice if they are not localized.  It checks that "local"
assignments in
>try_local_xy does take effect, and (more importantly) after try_local_xy
returns, the
>original values are restored.
>
>As I speculated earlier in an earlier message, the breakage you reported
may have to
>do with interaction between "local" and use of a subshell, and perhaps we
can also
>check that pattern in the test.
That is that I am also suggesting but did not say it as precisely. Thanks.
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 18 in “[Test Breakage 2.46.0-rc0] Test t0021.35 fails on NonStop”
  1. rsbecker@nexbridge.comJul 13, 2024
  2. Junio C HamanoJul 14, 2024
  3. rsbecker@nexbridge.comJul 14, 2024
  4. Junio C HamanoJul 14, 2024
  5. rsbecker@nexbridge.comJul 14, 2024
  6. brian m. carlsonJul 14, 2024
  7. rsbecker@nexbridge.comJul 14, 2024
  8. brian m. carlsonJul 14, 2024
  9. rsbecker@nexbridge.comJul 14, 2024
  10. Junio C HamanoJul 15, 2024
  11. rsbecker@nexbridge.comJul 15, 2024
  12. Junio C HamanoJul 15, 2024
  13. rsbecker@nexbridge.comJul 15, 2024
  14. Junio C HamanoJul 15, 2024
  15. rsbecker@nexbridge.comJul 15, 2024
  16. Junio C HamanoJul 15, 2024
  17. Eric SunshineJul 14, 2024
  18. rsbecker@nexbridge.comJul 14, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.