git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt

From
ABarnaud brejeon <arnaud.brejeon@gmail.com>
Date
Oct 21, 2013, 17:06 UTC
Message-ID
<005DF7EA-CF5A-408F-A145-07F53D836974@gmail.com>
In-Reply-To
<20131014233556.GA31230@dcvr.yhbt.net>

I played with GIT_ASKPASS and managed to get a fully automated behavior without any user prompt. I guess that the patches are not necessary as we can provide the same , it is just less straightforward than direct parameters but I understand the security concerns.

I dont know if you plan to keep GIT_ASKPASS as is, but this environment variable is not mentioned on git svn documentation and I guess just a few people know about it. Moreover, the name is misleading as it handles all the prompts, not only the password one.
Arnaud
Le 15 oct. 2013 à 01:35, Eric Wong <normalperson@yhbt.net> a écrit :
Show 39 quoted lines
> Jeff King <peff@peff.net> wrote:
>> On Mon, Oct 14, 2013 at 06:40:05PM +0000, Eric Wong wrote:
>> 
>>>> arnaud.brejeon@gmail.com wrote:
>>>> 
>>>>> Signed-off-by: Arnaud Brejeon <arnaud.brejeon <at> gmail.com>
>>>> 
>>>> Thanks.
>>>> 
>>>> Can you say a little more about the context?  Do you run a script that
>>>> wants to pass a password to 'git svn', do you type it each time on the
>>>> command line, or something else?  Is it ok that the password would
>>>> show up in "ps" output?  Would the platform's keyring or netrc be
>>>> usable here, or is there something in the context that avoids that?
>>> 
>>> I think using keyring or netrc is more appropriate.  Having a password
>>> on the command-line and visible to all via ps doesn't seem like
>>> something git should support.
>> 
>> Agreed. We have ready-made git-credential helpers to handle this exact
>> problem. We would need to convert SVN::Prompt to use git-credential
>> rather than prompting itself, though. One of the things that held me
>> back from writing such a patch is that I thought libsvn already handled
>> things like keychain integration, and it was better for git-svn to be
>> more svn-like than git-like in its access of SVN repos.
>> 
>> Are those already supported out of the box by libsvn? If git's
>> credential helpers are significantly more featureful, it might be worth
>> converting, but if not, I think it makes sense to stay with svn's
>> existing code.
> 
> I looks like this patch was forgotten once again:
> 
> http://mid.gmane.org/1371573490-21973-1-git-send-email-matthijs@stdin.nl
> 
> Matthijs: can you add a Signed-off-by for your patch?  I'm inclined to
> push it to Junio as-is since it looks reasonable.
> I admit I don't know SVN callbacks anymore well enough and don't have
> time to test with GNOME.
Previous: arnaud brejeonNext: Jeff King
Message 8 of 9 in “Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt”
  1. 1/2 Add password parameter to git svn commands and use it when provided instead of defaulting to end-user promptarnaud.brejeon@gmail.com, Oct 12, 2013
  2. 2/2 Add SVN trust-server-cert parameter to git svn to accept SSL server certificates from unknwon authorities without promptingarnaud.brejeon@gmail.com, Oct 12, 2013
  3. Jonathan NiederOct 14, 2013
  4. Eric WongOct 14, 2013
  5. Jeff KingOct 14, 2013
  6. Eric WongOct 14, 2013
  7. arnaud brejeonOct 15, 2013
  8. arnaud brejeonOct 21, 2013
  9. Jeff KingOct 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.