git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] Don't use curl_easy_strerror prior to curl-7.12.0

From
Joachim Schmitz <jojo@schmitz-digital.de>
Date
Aug 24, 2012, 09:58 UTC
Message-ID
<003001cd81df$0158cf60$040a6e20$@schmitz-digital.de>

This reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of libcURL.

Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
---
Resend, regardless that Junio said this not to be needed, as I don't see it applied yet.
Also tried to fix the formatting issues too, to practice submissions ;-)
 http.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/http.c b/http.c
index b61ac85..18bc6bf 100644
--- a/http.c
+++ b/http.c
@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result, int target, int options)
 				ret = HTTP_REAUTH;
 			}
 		} else {
+#if LIBCURL_VERSION_NUM >= 0x070c00
 			if (!curl_errorstr[0])
 				strlcpy(curl_errorstr,
 					curl_easy_strerror(results.curl_result),
 					sizeof(curl_errorstr));
+#endif
 			ret = HTTP_ERROR;
 		}
 	} else {
-- 
1.7.12
Message 1 of 1 in “Don't use curl_easy_strerror prior to curl-7.12.0”
  1. Don't use curl_easy_strerror prior to curl-7.12.0Joachim Schmitz, Aug 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.