threads / patch / 31340

v2Don't use curl_easy_strerror prior to curl-7.12.0

Subject: [PATCH v2] Don't use curl_easy_strerror prior to curl-7.12.0

## tl;dr

One message between Aug 24, 2012 and Aug 24, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Joachim Schmitz· Aug 24, 2012, 09:58 UTC · lore

This reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of libcURL.

Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
---
Resend, regardless that Junio said this not to be needed, as I don't see it applied yet.
Also tried to fix the formatting issues too, to practice submissions ;-)
 http.c | 2 ++
 1 file changed, 2 insertions(+)
Show changes to http.c +2 −0
diff --git a/http.c b/http.c
index b61ac85..18bc6bf 100644
--- a/http.c
+++ b/http.c
@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result, int target, int options)
 				ret = HTTP_REAUTH;
 			}
 		} else {
+#if LIBCURL_VERSION_NUM >= 0x070c00
 			if (!curl_errorstr[0])
 				strlcpy(curl_errorstr,
 					curl_easy_strerror(results.curl_result),
 					sizeof(curl_errorstr));
+#endif
 			ret = HTTP_ERROR;
 		}
 	} else {
-- 
1.7.12

← back to recent threads