Re: [OUTREACHY][PATCH v2] t7006: Use test_path_is_* functions in test script
- From
- Joey Salazar <jgsal@protonmail.com>
- Date
- Oct 21, 2020, 22:21 UTC
- Message-ID
- <-fqjNpjuA1NlG29AeRtBDgTHlHbtljRImPvtORqdjK7QXE7fOn8GyzCWlgYj-eZvfj_sNPuCjHoh70xUyfusx1myQYR9HzfiM14M-96cBL0=@protonmail.com>
- In-Reply-To
- <xmqqft675jjv.fsf@gitster.c.googlers.com>
Will do, thank you.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, October 21, 2020 3:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Joey Salazar jgsal@protonmail.com writes: > > > Hi Phillip, Junio, > > Thank you for your reviews and support, they're much appreciated and I'm happy the patch looks ok. > > > > > I'll probably have to hand-edit the authorship before applying > > > (check the From: of the e-mail) so that the identity on the > > > signed-off-by trailer matches the author, but other than that the > > > patch looks quite good to me, too. > > > > My big apologies Junio, I mistook "authorship" to mean my `git config --global user.name` and `git config --global user.email` settings. > > Should I resend the patch email? > > No need to apologize and no need to resend. You may want to send a > patch to yourself to prepare your procedure, but that is something > you can do without sending patches to the list. > > Thanks.