threads / patch / 9931

patchPrevent using bold text in entire gui for some fonts sometimes

Subject: [PATCH] Prevent using bold text in entire gui for some fonts sometimes

## tl;dr

2 messages between Sep 18, 2007 and Sep 20, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Simon Sasburg· Sep 18, 2007, 22:33 UTC · lore

---

When I first saw git-gui on windows, I noticed it wasn't using ugly bold fonts for it's entire gui like it was in linux. I came up with the following patch to fix this there.

And it worked, trange thing was, even git-gui without this patch applied was using normal fonts now. The patch didn't seem to make any difference for me anymore. So I chalked this up to weirdness of my system.

Yesterday though a saw that a friends git-gui was showing the same problem with the entire gui being in bold text. And this patch fixed it.

So its a bit weird that this patch seemed to have 'permanent' effects for me, even after it was reverted.... but on the other hand it's really trivial.

 git-gui/git-gui.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-gui/git-gui.sh +1 −1

diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index f789e91..28d7c21 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -1648,7 +1648,7 @@ proc apply_config {} {
 		set font [lindex $option 1]
 		if {[catch {
 			foreach {cn cv} $repo_config(gui.$name) {
-				font configure $font $cn $cv
+				font configure $font $cn $cv -weight normal
 			}
 			} err]} {
 			error_popup "Invalid font specified in gui.$name:\n\n$err"

-- 
1.5.3.1.21.g997f2-dirty

Shawn O. Pearce· Sep 20, 2007, 17:01 UTC · re: Simon Sasburg · lore

Re: [PATCH] Prevent using bold text in entire gui for some fonts sometimes

Simon Sasburg <simon.sasburg@gmail.com> wrote:

Show 16 quoted lines

> When I first saw git-gui on windows, I noticed it wasn't using ugly
> bold fonts for it's entire gui like it was in linux. I came up with
> the following patch to fix this there.
> 
> And it worked, trange thing was, even git-gui without this patch
> applied was using normal fonts now. The patch didn't seem to make any
> difference for me anymore. So I chalked this up to weirdness of my
> system.
> 
> Yesterday though a saw that a friends git-gui was showing the same
> problem with the entire gui being in bold text. And this patch fixed
> it.
> 
> So its a bit weird that this patch seemed to have 'permanent' effects
> for me, even after it was reverted.... but on the other hand it's
> really trivial.

Yea, I can't explain that either. But this patch is really trivial so I'm applying it anyway. Doesn't break anyone who was already using a normal weight on their font and it should prevent others from picking up bold everywhere. Thanks.

-- 
Shawn.