{"thread":{"id":"9931","subject":"[PATCH] Prevent using bold text in entire gui for some fonts sometimes","startedAt":"2007-09-18T22:33:34Z","lastAt":"2007-09-20T17:01:24Z","messageCount":2,"participants":["Simon Sasburg","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"53514","messageId":"981e6de60709181533o24ef0e45w7925070b5e78ef56@mail.gmail.com","threadId":"9931","inReplyTo":null,"subject":"[PATCH] Prevent using bold text in entire gui for some fonts sometimes","fromName":"Simon Sasburg","fromEmail":"simon.sasburg@gmail.com","sentAt":"2007-09-18T22:33:34Z","receivedAt":"2007-09-18T22:33:34Z","isPatch":true,"sender":{"key":"simon.sasburg@gmail.com","avatar":null},"body":"---\n\nWhen I first saw git-gui on windows, I noticed it wasn't using ugly\nbold fonts for it's entire gui like it was in linux. I came up with\nthe following patch to fix this there.\n\nAnd it worked, trange thing was, even git-gui without this patch\napplied was using normal fonts now. The patch didn't seem to make any\ndifference for me anymore. So I chalked this up to weirdness of my\nsystem.\n\nYesterday though a saw that a friends git-gui was showing the same\nproblem with the entire gui being in bold text. And this patch fixed\nit.\n\nSo its a bit weird that this patch seemed to have 'permanent' effects\nfor me, even after it was reverted.... but on the other hand it's\nreally trivial.\n\n git-gui/git-gui.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex f789e91..28d7c21 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -1648,7 +1648,7 @@ proc apply_config {} {\n \t\tset font [lindex $option 1]\n \t\tif {[catch {\n \t\t\tforeach {cn cv} $repo_config(gui.$name) {\n-\t\t\t\tfont configure $font $cn $cv\n+\t\t\t\tfont configure $font $cn $cv -weight normal\n \t\t\t}\n \t\t\t} err]} {\n \t\t\terror_popup \"Invalid font specified in gui.$name:\\n\\n$err\"\n-- \n1.5.3.1.21.g997f2-dirty\n"},{"id":"53656","messageId":"20070920170124.GS3099@spearce.org","threadId":"9931","inReplyTo":"981e6de60709181533o24ef0e45w7925070b5e78ef56@mail.gmail.com","subject":"Re: [PATCH] Prevent using bold text in entire gui for some fonts sometimes","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-09-20T17:01:24Z","receivedAt":"2007-09-20T17:01:24Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Simon Sasburg <simon.sasburg@gmail.com> wrote:\n> When I first saw git-gui on windows, I noticed it wasn't using ugly\n> bold fonts for it's entire gui like it was in linux. I came up with\n> the following patch to fix this there.\n> \n> And it worked, trange thing was, even git-gui without this patch\n> applied was using normal fonts now. The patch didn't seem to make any\n> difference for me anymore. So I chalked this up to weirdness of my\n> system.\n> \n> Yesterday though a saw that a friends git-gui was showing the same\n> problem with the entire gui being in bold text. And this patch fixed\n> it.\n> \n> So its a bit weird that this patch seemed to have 'permanent' effects\n> for me, even after it was reverted.... but on the other hand it's\n> really trivial.\n\nYea, I can't explain that either.  But this patch is really trivial\nso I'm applying it anyway.  Doesn't break anyone who was already\nusing a normal weight on their font and it should prevent others\nfrom picking up bold everywhere.  Thanks.\n\n-- \nShawn.\n"}]}