[PATCH] git-gui: remove dots in some UI strings

Michele Ballabio· Sep 2, 2007, 12:43 UTC · lore

Dots in a UI string usually mean that a dialog box will appear waiting for further input. So this patch removes unneeded dots for actions that do not require user's input.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
---
 lib/remote.tcl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Show changes to lib/remote.tcl +3 −3

diff --git a/lib/remote.tcl b/lib/remote.tcl
index cf9b9d5..99ec1b4 100644
--- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -159,7 +159,7 @@ proc populate_fetch_menu {} {
 		if {$enable} {
 			lappend prune_list $r
 			$m add command \
-				-label "Fetch from $r..." \
+				-label "Fetch from $r" \
 				-command [list fetch_from $r]
 		}
 	}
@@ -169,7 +169,7 @@ proc populate_fetch_menu {} {
 	}
 	foreach r $prune_list {
 		$m add command \
-			-label "Prune from $r..." \
+			-label "Prune from $r" \
 			-command [list prune_from $r]
 	}
 }
@@ -203,7 +203,7 @@ proc populate_push_menu {} {
 				$m add separator
 			}
 			$m add command \
-				-label "Push to $r..." \
+				-label "Push to $r" \
 				-command [list push_to $r]
 			incr fast_count
 		}

-- 
1.5.3.rc7

Shawn O. Pearce· Sep 3, 2007, 04:51 UTC · re: Michele Ballabio · lore

Re: [PATCH] git-gui: remove dots in some UI strings

Michele Ballabio <barra_cuda@katamail.com> wrote:

> Dots in a UI string usually mean that a dialog box will
> appear waiting for further input. So this patch removes
> unneeded dots for actions that do not require user's
> input.

Thanks, that's a good usability improvement.  I had already merged
the i18n work that everyone has been working on so I adjusted your
patch to apply on top of that series and pushed everything back
out in my master branch.

-- 
Shawn.

patchgit-gui: remove dots in some UI strings