{"thread":{"id":"9748","subject":"[PATCH] git-gui: remove dots in some UI strings","startedAt":"2007-09-02T12:43:00Z","lastAt":"2007-09-03T04:51:18Z","messageCount":2,"participants":["Michele Ballabio","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"52211","messageId":"200709021443.00144.barra_cuda@katamail.com","threadId":"9748","inReplyTo":null,"subject":"[PATCH] git-gui: remove dots in some UI strings","fromName":"Michele Ballabio","fromEmail":"barra_cuda@katamail.com","sentAt":"2007-09-02T12:43:00Z","receivedAt":"2007-09-02T12:43:00Z","isPatch":true,"sender":{"key":"barra_cuda@katamail.com","avatar":"https://avatars.githubusercontent.com/u/16371673?v=4"},"body":"Dots in a UI string usually mean that a dialog box will\nappear waiting for further input. So this patch removes\nunneeded dots for actions that do not require user's\ninput.\n\nSigned-off-by: Michele Ballabio <barra_cuda@katamail.com>\n---\n lib/remote.tcl |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/lib/remote.tcl b/lib/remote.tcl\nindex cf9b9d5..99ec1b4 100644\n--- a/lib/remote.tcl\n+++ b/lib/remote.tcl\n@@ -159,7 +159,7 @@ proc populate_fetch_menu {} {\n \t\tif {$enable} {\n \t\t\tlappend prune_list $r\n \t\t\t$m add command \\\n-\t\t\t\t-label \"Fetch from $r...\" \\\n+\t\t\t\t-label \"Fetch from $r\" \\\n \t\t\t\t-command [list fetch_from $r]\n \t\t}\n \t}\n@@ -169,7 +169,7 @@ proc populate_fetch_menu {} {\n \t}\n \tforeach r $prune_list {\n \t\t$m add command \\\n-\t\t\t-label \"Prune from $r...\" \\\n+\t\t\t-label \"Prune from $r\" \\\n \t\t\t-command [list prune_from $r]\n \t}\n }\n@@ -203,7 +203,7 @@ proc populate_push_menu {} {\n \t\t\t\t$m add separator\n \t\t\t}\n \t\t\t$m add command \\\n-\t\t\t\t-label \"Push to $r...\" \\\n+\t\t\t\t-label \"Push to $r\" \\\n \t\t\t\t-command [list push_to $r]\n \t\t\tincr fast_count\n \t\t}\n-- \n1.5.3.rc7\n"},{"id":"52299","messageId":"20070903045118.GR18160@spearce.org","threadId":"9748","inReplyTo":"200709021443.00144.barra_cuda@katamail.com","subject":"Re: [PATCH] git-gui: remove dots in some UI strings","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-09-03T04:51:18Z","receivedAt":"2007-09-03T04:51:18Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Michele Ballabio <barra_cuda@katamail.com> wrote:\n> Dots in a UI string usually mean that a dialog box will\n> appear waiting for further input. So this patch removes\n> unneeded dots for actions that do not require user's\n> input.\n\nThanks, that's a good usability improvement.  I had already merged\nthe i18n work that everyone has been working on so I adjusted your\npatch to apply on top of that series and pushed everything back\nout in my master branch.\n \n-- \nShawn.\n"}]}