threads / patch / 9718

patchTest for windows format absolute paths on cygwin too

Subject: [PATCH] Test for windows format absolute paths on cygwin too

## tl;dr

3 messages between Aug 31, 2007 and Aug 31, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Robin Rosenberg· Aug 31, 2007, 09:07 UTC · lore

---

Requires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86

 sha1_file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to sha1_file.c +1 −2

diff --git a/sha1_file.c b/sha1_file.c
index 97ea448..fa867b8 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -84,7 +84,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1)
 /* returns the number of chars to skip to first component */
 static inline int is_path_absolute(const char *path)
 {
-#ifdef __MINGW32__
+#if defined(__MINGW32__) || defined(__CYGWIN__)
 	if (isalpha(path[0]) && path[1] == ':')
 		return 2 + (path[2] == '/');
 	/* TODO: C:dir/file 'relative' paths are not catered for */
--
1.5.3.rc7.25.g5389f-dirty

Johannes Sixt· Aug 31, 2007, 09:31 UTC · re: Robin Rosenberg · lore

Re: [PATCH] Test for windows format absolute paths on cygwin too

Robin Rosenberg schrieb:

> ---
> 
> Requires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86

... which you find in mingw.git.

However, that commit is not signed-off for a reason: It is going to be rewritten mostly because it doesn't yet use the is_absolute_path() from git-compat-util.h.

-- Hannes

Robin Rosenberg· Aug 31, 2007, 21:07 UTC · re: Johannes Sixt · lore

Re: [PATCH] Test for windows format absolute paths on cygwin too

fredag 31 augusti 2007 skrev Johannes Sixt:

Show 6 quoted lines

> Robin Rosenberg schrieb:
> > ---
> > 
> > Requires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86
> 
> ... which you find in mingw.git.

> 
> However, that commit is not signed-off for a reason: It is going to be 
> rewritten mostly because it doesn't yet use the is_absolute_path() from 
> git-compat-util.h.

Ah, yes. It can probably wait. I needed this for the Eclipse Git plugin to work nicely wth shared cloned repos under cygwin. With full clones there is no such problem. Before the patch I created two references, one for cygwin and one for EGIT, but cygwin was very noisy with that workaround and git-gui/gitk didn't work reliably when they did work at all.

-- robin