{"thread":{"id":"9718","subject":"[PATCH] Test for windows format absolute paths on cygwin too","startedAt":"2007-08-31T09:07:20Z","lastAt":"2007-08-31T21:07:07Z","messageCount":3,"participants":["Robin Rosenberg","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"52011","messageId":"xMhwifY1.1188551240.4001640.roro@localhost","threadId":"9718","inReplyTo":null,"subject":"[PATCH] Test for windows format absolute paths on cygwin too","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-08-31T09:07:20Z","receivedAt":"2007-08-31T09:07:20Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"---\n\nRequires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86\n\n sha1_file.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/sha1_file.c b/sha1_file.c\nindex 97ea448..fa867b8 100644\n--- a/sha1_file.c\n+++ b/sha1_file.c\n@@ -84,7 +84,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1)\n /* returns the number of chars to skip to first component */\n static inline int is_path_absolute(const char *path)\n {\n-#ifdef __MINGW32__\n+#if defined(__MINGW32__) || defined(__CYGWIN__)\n \tif (isalpha(path[0]) && path[1] == ':')\n \t\treturn 2 + (path[2] == '/');\n \t/* TODO: C:dir/file 'relative' paths are not catered for */\n--\n1.5.3.rc7.25.g5389f-dirty\n"},{"id":"52013","messageId":"46D7DFE0.6040606@eudaptics.com","threadId":"9718","inReplyTo":"xMhwifY1.1188551240.4001640.roro@localhost","subject":"Re: [PATCH] Test for windows format absolute paths on cygwin too","fromName":"Johannes Sixt","fromEmail":"j.sixt@eudaptics.com","sentAt":"2007-08-31T09:31:12Z","receivedAt":"2007-08-31T09:31:12Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Robin Rosenberg schrieb:\n> ---\n> \n> Requires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86\n\n... which you find in mingw.git.\n\nHowever, that commit is not signed-off for a reason: It is going to be \nrewritten mostly because it doesn't yet use the is_absolute_path() from \ngit-compat-util.h.\n\n-- Hannes\n"},{"id":"52079","messageId":"200708312307.07930.robin.rosenberg.lists@dewire.com","threadId":"9718","inReplyTo":"46D7DFE0.6040606@eudaptics.com","subject":"Re: [PATCH] Test for windows format absolute paths on cygwin too","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-08-31T21:07:07Z","receivedAt":"2007-08-31T21:07:07Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"fredag 31 augusti 2007 skrev Johannes Sixt:\n> Robin Rosenberg schrieb:\n> > ---\n> > \n> > Requires cherry-picking 6397c3119ecaa258b5185315c64062bec29bcd86\n> \n> ... which you find in mingw.git.\n\n> \n> However, that commit is not signed-off for a reason: It is going to be \n> rewritten mostly because it doesn't yet use the is_absolute_path() from \n> git-compat-util.h.\n\nAh, yes. It can probably wait. I needed this for the Eclipse Git plugin to work\nnicely wth shared cloned repos under cygwin. With full clones there is no such\nproblem. Before the patch I created two references, one for cygwin and one\nfor EGIT, but cygwin was very noisy with that workaround and git-gui/gitk didn't\nwork reliably when they did work at all.\n\n-- robin\n"}]}