threads / patch / 9670

patchbuiltin-push: New long option --verbose

Subject: [PATCH] builtin-push: New long option --verbose

## tl;dr

8 messages between Aug 27, 2007 and Aug 27, 2007. Diffs are folded; open one to read it.

replies: 7people: 4as markdown or json

Jari Aalto· Aug 27, 2007, 06:49 UTC · lore
Implemented and documented new option.
Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 Documentation/git-push.txt |    4 ++--
 builtin-push.c             |    5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)
Show changes to 2 files +5 −4

Documentation/git-push.txt, builtin-push.c

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index f8cc2b5..fb9dc7f 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -8,7 +8,7 @@ git-push - Update remote refs along with associated objects
 
 SYNOPSIS
 --------
-'git-push' [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v] [<repository> <refspec>...]
+'git-push' [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v | --verbose] [<repository> <refspec>...]
 
 DESCRIPTION
 -----------
@@ -91,7 +91,7 @@ the remote repository.
 	transfer spends extra cycles to minimize the number of
 	objects to be sent and meant to be used on slower connection.
 
--v::
+-v, \--verbose::
 	Run verbosely.
 
 include::urls.txt[]
diff --git a/builtin-push.c b/builtin-push.c
index cb78401..613f6c2 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -8,7 +8,7 @@
 
 #define MAX_URI (16)
 
-static const char push_usage[] = "git-push [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v] [<repository> <refspec>...]";
+static const char push_usage[] = "git-push [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v | --verbose] [<repository> <refspec>...]";
 
 static int all, tags, force, thin = 1, verbose;
 static const char *receivepack;
@@ -372,7 +372,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)
 			i++;
 			break;
 		}
-		if (!strcmp(arg, "-v")) {
+		if (!strcmp(arg, "-v") ||
+                    !strcmp(arg, "--verbose")) {
 			verbose=1;
 			continue;
 		}

-- 
1.5.3.rc5
David Kågedal· Aug 27, 2007, 08:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] builtin-push: New long option --verbose

Junio C Hamano <gitster@pobox.com> writes:
> Why?

One reason is that I often don't know if the program I want to run (git or something sles) uses -v as the "verbose" flag, or if it's the "version" flag or something else. But if there is a --verbose flag, I can be sure what it is, so I often try that first if I'm unsure. If that faild, I'll probably look in the man page.

-- 
David Kågedal
Jari Aalto· Aug 27, 2007, 13:32 UTC · re: Junio C Hamano · lore

Re: [PATCH] builtin-push: New long option --verbose

Junio C Hamano <gitster@pobox.com> writes:
> Why?

It complements the command set. -v was the only lonely that did not have long option choice.

Overall, the option handling in every command could use aboot to provide both short and long options. Now various commands have short ones, but no long ones, or vice versa. It's like sherwood there.

Let's start unifying. Jari

Johannes Schindelin· Aug 27, 2007, 13:48 UTC · re: Jari Aalto · lore

Re: [PATCH] builtin-push: New long option --verbose

Hi,
On Mon, 27 Aug 2007, Jari Aalto wrote:
Show 6 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Why?
> 
> It complements the command set. -v was the only lonely that did not
> have long option choice.

Of course, the _proper_ solution would be to introduce a complete option parser component a la getopt. For me, it is not _half_ as annoying that some short/long options are missing than being unable to abbreviate the short options into something like "-nls".

Ciao, Dscho

Johannes Schindelin· Aug 27, 2007, 08:40 UTC · re: Jari Aalto · lore

Re: [PATCH] builtin-push: New long option --verbose

Hi,
On Mon, 27 Aug 2007, Jari Aalto wrote:
> Implemented and documented new option.
It is not "new".  It is just a long form for the already existing "-v".

Ciao, Dscho

Jari Aalto· Aug 27, 2007, 13:30 UTC · re: Johannes Schindelin · lore

Re: [PATCH] builtin-push: New long option --verbose

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> Hi,
>
> On Mon, 27 Aug 2007, Jari Aalto wrote:
>
>> Implemented and documented new option.
>
> It is not "new".  It is just a long form for the already existing "-v".
Perception is in the eye. "new long option"
                               ===========
Jari
Johannes Schindelin· Aug 27, 2007, 13:45 UTC · re: Jari Aalto · lore

Re: [PATCH] builtin-push: New long option --verbose

Hi,
[please, if you reply to my message, do not kill me from the address list]
On Mon, 27 Aug 2007, Jari Aalto wrote:
Show 10 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 27 Aug 2007, Jari Aalto wrote:
> >
> >> Implemented and documented new option.
> >
> > It is not "new".  It is just a long form for the already existing "-v".
> 
> Perception is in the eye. "new long option"
>                                ===========
More appropriate: "Add long option --verbose".

Even as a long option, it is not new. There have been plenty "--verbose"s in git before.

It might appear to you as a minor nit, but reading commit logs it is pretty disruptive to read about the "new" option and wondering "why the heck was it not there before? Ah, it was. The committer just added the long version of the option".

Ciao, Dscho

← back to recent threads