{"thread":{"id":"9670","subject":"[PATCH] builtin-push: New long option --verbose","startedAt":"2007-08-27T06:49:11Z","lastAt":"2007-08-27T13:48:43Z","messageCount":8,"participants":["Jari Aalto","Junio C Hamano","Johannes Schindelin","David Kågedal"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"51639","messageId":"y7fxeal4.fsf@cante.net","threadId":"9670","inReplyTo":null,"subject":"[PATCH] builtin-push: New long option --verbose","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-08-27T06:49:11Z","receivedAt":"2007-08-27T06:49:11Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"Implemented and documented new option.\n\nSigned-off-by: Jari Aalto \n---\n Documentation/git-push.txt | 4 ++--\n builtin-push.c | 5 +++--\n 2 files changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-push.txt b/Documentation/git-push.txt\nindex f8cc2b5..fb9dc7f 100644\n--- a/Documentation/git-push.txt\n+++ b/Documentation/git-push.txt\n@@ -8,7 +8,7 @@ git-push - Update remote refs along with associated objects\n \n SYNOPSIS\n --------\n-'git-push' [--all] [--tags] [--receive-pack=] [--repo=all] [-f | --force] [-v] [ ...]\n+'git-push' [--all] [--tags] [--receive-pack=] [--repo=all] [-f | --force] [-v | --verbose] [ ...]\n \n DESCRIPTION\n -----------\n@@ -91,7 +91,7 @@ the remote repository.\n \ttransfer spends extra cycles to minimize the number of\n \tobjects to be sent and meant to be used on slower connection.\n \n--v::\n+-v, \\--verbose::\n \tRun verbosely.\n \n include::urls.txt[]\ndiff --git a/builtin-push.c b/builtin-push.c\nindex cb78401..613f6c2 100644\n--- a/builtin-push.c\n+++ b/builtin-push.c\n@@ -8,7 +8,7 @@\n \n #define MAX_URI (16)\n \n-static const char push_usage[] = \"git-push [--all] [--tags] [--receive-pack=] [--repo=all] [-f | --force] [-v] [ ...]\";\n+static const char push_usage[] = \"git-push [--all] [--tags] [--receive-pack=] [--repo=all] [-f | --force] [-v | --verbose] [ ...]\";\n \n static int all, tags, force, thin = 1, verbose;\n static const char *receivepack;\n@@ -372,7 +372,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)\n \t\t\ti++;\n \t\t\tbreak;\n \t\t}\n-\t\tif (!strcmp(arg, \"-v\")) {\n+\t\tif (!strcmp(arg, \"-v\") ||\n+ !strcmp(arg, \"--verbose\")) {\n \t\t\tverbose=1;\n \t\t\tcontinue;\n \t\t}\n-- \n1.5.3.rc5\n"},{"id":"51646","messageId":"7vtzqll7hf.fsf@gitster.siamese.dyndns.org","threadId":"9670","inReplyTo":"y7fxeal4.fsf@cante.net","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-27T08:14:20Z","receivedAt":"2007-08-27T08:14:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Why?\n"},{"id":"51653","messageId":"Pine.LNX.4.64.0708270940130.28586@racer.site","threadId":"9670","inReplyTo":"y7fxeal4.fsf@cante.net","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-08-27T08:40:40Z","receivedAt":"2007-08-27T08:40:40Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 27 Aug 2007, Jari Aalto wrote:\n\n> Implemented and documented new option.\n\nIt is not \"new\". It is just a long form for the already existing \"-v\".\n\nCiao,\nDscho\n"},{"id":"51661","messageId":"878x7xjr7b.fsf@morpheus.local","threadId":"9670","inReplyTo":"7vtzqll7hf.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2007-08-27T08:51:20Z","receivedAt":"2007-08-27T08:51:20Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"Junio C Hamano writes:\n\n> Why?\n\nOne reason is that I often don't know if the program I want to run\n(git or something sles) uses -v as the \"verbose\" flag, or if it's the\n\"version\" flag or something else. But if there is a --verbose flag, I\ncan be sure what it is, so I often try that first if I'm unsure. If\nthat faild, I'll probably look in the man page.\n\n-- \nDavid Kågedal\n"},{"id":"51702","messageId":"ps19drzl.fsf@cante.net","threadId":"9670","inReplyTo":"Pine.LNX.4.64.0708270940130.28586@racer.site","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-08-27T13:30:54Z","receivedAt":"2007-08-27T13:30:54Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On Mon, 27 Aug 2007, Jari Aalto wrote:\n>\n>> Implemented and documented new option.\n>\n> It is not \"new\". It is just a long form for the already existing \"-v\".\n\nPerception is in the eye. \"new long option\"\n ===========\n\nJari\n"},{"id":"51705","messageId":"lkbxdrwg.fsf@cante.net","threadId":"9670","inReplyTo":"7vtzqll7hf.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-08-27T13:32:47Z","receivedAt":"2007-08-27T13:32:47Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"Junio C Hamano writes:\n\n> Why?\n\nIt complements the command set. -v was the only lonely that did not\nhave long option choice.\n\nOverall, the option handling in every command could use aboot to\nprovide both short and long options. Now various commands have short\nones, but no long ones, or vice versa. It's like sherwood there.\n\nLet's start unifying.\nJari\n"},{"id":"51707","messageId":"Pine.LNX.4.64.0708271443300.28586@racer.site","threadId":"9670","inReplyTo":"ps19drzl.fsf@cante.net","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-08-27T13:45:41Z","receivedAt":"2007-08-27T13:45:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\n[please, if you reply to my message, do not kill me from the address list]\n\nOn Mon, 27 Aug 2007, Jari Aalto wrote:\n\n> Johannes Schindelin writes:\n> \n> > On Mon, 27 Aug 2007, Jari Aalto wrote:\n> >\n> >> Implemented and documented new option.\n> >\n> > It is not \"new\". It is just a long form for the already existing \"-v\".\n> \n> Perception is in the eye. \"new long option\"\n> ===========\n\nMore appropriate: \"Add long option --verbose\".\n\nEven as a long option, it is not new. There have been plenty \"--verbose\"s \nin git before.\n\nIt might appear to you as a minor nit, but reading commit logs it is \npretty disruptive to read about the \"new\" option and wondering \"why the \nheck was it not there before? Ah, it was. The committer just added the \nlong version of the option\".\n\nCiao,\nDscho\n"},{"id":"51708","messageId":"Pine.LNX.4.64.0708271447120.28586@racer.site","threadId":"9670","inReplyTo":"lkbxdrwg.fsf@cante.net","subject":"Re: [PATCH] builtin-push: New long option --verbose","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-08-27T13:48:43Z","receivedAt":"2007-08-27T13:48:43Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 27 Aug 2007, Jari Aalto wrote:\n\n> Junio C Hamano writes:\n> \n> > Why?\n> \n> It complements the command set. -v was the only lonely that did not\n> have long option choice.\n\nOf course, the _proper_ solution would be to introduce a complete option \nparser component a la getopt. For me, it is not _half_ as annoying that \nsome short/long options are missing than being unable to abbreviate the \nshort options into something like \"-nls\".\n\nCiao,\nDscho\n"}]}