[PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary

David Kastrup· Aug 12, 2007, 08:02 UTC · lore

Signed-off-by: David Kastrup <dak@gnu.org>
---
I have not actually tested this, but from staring at it intensively,
it should be correct.  One of the things that bit me when I tried
using this program.

 git-send-email.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Show changes to git-send-email.perl +2 −1

diff --git a/git-send-email.perl b/git-send-email.perl
index 69559b2..877f74c 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -309,7 +309,8 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 	} while (!defined $_);
 
 	$initial_reply_to = $_;
-	$initial_reply_to =~ s/(^\s+|\s+$)//g;
+	$initial_reply_to =~ s/^\s+<?/</;
+	$initial_reply_to =~ s/>?\s+$/>/;
 }
 
 if (!$smtp_server) {

-- 
1.5.3.rc2.187.g9a1d2-dirty

Uwe Kleine-König· Aug 12, 2007, 12:49 UTC · re: David Kastrup · lore

Re: [PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary

Hello David,

Show 9 quoted lines

> I have not actually tested this, but from staring at it intensively,
> it should be correct.  One of the things that bit me when I tried
> using this program.
> 
> ...
> -	$initial_reply_to =~ s/(^\s+|\s+$)//g;
> +	$initial_reply_to =~ s/^\s+<?/</;
> +	$initial_reply_to =~ s/>?\s+$/>/;
> ...

some rules from rfc822:

	optional-field	= ... / "In-Reply-To:"  *(phrase / msg-id) / ...
	msg-id		= "<" addr-spec ">"
	phrase		= 1*word
	word		= atom / quoted-string
	atom		= 1*<any CHAR except specials, SPACE and CTLs>
	quoted-string	= <"> *(qtext/quoted-pair) <">
	...

With 1*... meaning "one or more" and *... meaning "zero or more".

That is not all fields of In-Reply-To: must be enclosed in '<', '>'. I didn't know that before looking it up and I expect it's not very common. Even if no "phrase" is used there can be multiple msg-id's and then your patch doesn't do the right thing.

But anyhow I think it's bearable to include these angle brackets in the cut-and-paste process.

Best regards Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=1+electron+mass%3D

patchgit-send-email.perl: Add angle brackets to In-Reply-To if necessary