{"thread":{"id":"9500","subject":"[PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary","startedAt":"2007-08-12T08:02:47Z","lastAt":"2007-08-12T12:49:01Z","messageCount":2,"participants":["David Kastrup","Uwe Kleine-König"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"50538","messageId":"85lkchqixk.fsf@lola.goethe.zz","threadId":"9500","inReplyTo":null,"subject":"[PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-08-12T08:02:47Z","receivedAt":"2007-08-12T08:02:47Z","isPatch":true,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\nSigned-off-by: David Kastrup <dak@gnu.org>\n---\nI have not actually tested this, but from staring at it intensively,\nit should be correct.  One of the things that bit me when I tried\nusing this program.\n\n git-send-email.perl |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 69559b2..877f74c 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -309,7 +309,8 @@ if ($thread && !defined $initial_reply_to && $prompting) {\n \t} while (!defined $_);\n \n \t$initial_reply_to = $_;\n-\t$initial_reply_to =~ s/(^\\s+|\\s+$)//g;\n+\t$initial_reply_to =~ s/^\\s+<?/</;\n+\t$initial_reply_to =~ s/>?\\s+$/>/;\n }\n \n if (!$smtp_server) {\n-- \n1.5.3.rc2.187.g9a1d2-dirty\n"},{"id":"50550","messageId":"20070812124901.GA9662@informatik.uni-freiburg.de","threadId":"9500","inReplyTo":"85lkchqixk.fsf@lola.goethe.zz","subject":"Re: [PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-08-12T12:49:01Z","receivedAt":"2007-08-12T12:49:01Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hello David,\n\n> I have not actually tested this, but from staring at it intensively,\n> it should be correct.  One of the things that bit me when I tried\n> using this program.\n> \n> ...\n> -\t$initial_reply_to =~ s/(^\\s+|\\s+$)//g;\n> +\t$initial_reply_to =~ s/^\\s+<?/</;\n> +\t$initial_reply_to =~ s/>?\\s+$/>/;\n> ...\n\nsome rules from rfc822:\n\n\toptional-field\t= ... / \"In-Reply-To:\"  *(phrase / msg-id) / ...\n\tmsg-id\t\t= \"<\" addr-spec \">\"\n\tphrase\t\t= 1*word\n\tword\t\t= atom / quoted-string\n\tatom\t\t= 1*<any CHAR except specials, SPACE and CTLs>\n\tquoted-string\t= <\"> *(qtext/quoted-pair) <\">\n\t...\n\nWith 1*... meaning \"one or more\" and *... meaning \"zero or more\".\n\nThat is not all fields of In-Reply-To: must be enclosed in '<', '>'.  I\ndidn't know that before looking it up and I expect it's not very common.\nEven if no \"phrase\" is used there can be multiple msg-id's and then your\npatch doesn't do the right thing.\n\nBut anyhow I think it's bearable to include these angle brackets in the\ncut-and-paste process.\n\nBest regards\nUwe\n\n-- \nUwe Kleine-König\n\nhttp://www.google.com/search?q=1+electron+mass%3D\n"}]}