threads / patch / 9225

patch, 2 partsuse lockfile.c routines in git_commit_set_multivar()

Subject: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()

## tl;dr

3 messages between Jul 25, 2007 and Jul 26, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Junio C Hamano· Jul 25, 2007, 23:39 UTC · lore
    From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
    Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
    Date: Wed, 25 Jul 2007 12:49:53 -0400
    Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
    Changed git_commit_set_multivar() to use the routines provided by
    lockfile.c to reduce code duplication and ensure consistent behavior.
    Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>

Dscho, I think this is worth doing regardless of that "symlinked config" issue. I haven't followed the code closely enough, though.

What do you think?
Johannes Schindelin· Jul 26, 2007, 03:31 UTC · re: Junio C Hamano · lore

Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()

Hi,
On Wed, 25 Jul 2007, Junio C Hamano wrote:
Show 15 quoted lines
>     From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
>     Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
>     Date: Wed, 25 Jul 2007 12:49:53 -0400
>     Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
> 
>     Changed git_commit_set_multivar() to use the routines provided by
>     lockfile.c to reduce code duplication and ensure consistent behavior.
> 
>     Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
> 
> Dscho, I think this is worth doing regardless of that "symlinked
> config" issue.  I haven't followed the code closely enough,
> though.
> 
> What do you think?

I think that I will review it tomorrow; this darned work-tree stuff took way longer than expected.

Ciao, Dscho

Johannes Schindelin· Jul 26, 2007, 18:26 UTC · lore

Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()

Hi,
On Thu, 26 Jul 2007, Bradford Smith wrote:
Show 5 quoted lines
> Dear Dscho,
> 
> I've submitted a slightly modified version of the same patch to the list.
> It fixes a comment format to match the approved style for git code.  Please
> review that one instead.
I saw it and am reviewing it!

Ciao, Dscho

← back to recent threads