# [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() 3 messages from 2007-07-25 to 2007-07-26. Participants: Junio C Hamano, Johannes Schindelin. Thread: https://gitlist.dev/t/9225 ## Junio C Hamano, 2007-07-25 23:39 Subject: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Message-ID: <7v7ioocatt.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v7ioocatt.fsf%40assigned-by-dhcp.cox.net ``` From: "Bradford C. Smith" Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Date: Wed, 25 Jul 2007 12:49:53 -0400 Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com> Changed git_commit_set_multivar() to use the routines provided by lockfile.c to reduce code duplication and ensure consistent behavior. Signed-off-by: "Bradford C. Smith" Dscho, I think this is worth doing regardless of that "symlinked config" issue. I haven't followed the code closely enough, though. What do you think? ``` ## Johannes Schindelin, 2007-07-26 03:31 Subject: Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0707260431240.14781%40racer.site In-Reply-To: <7v7ioocatt.fsf@assigned-by-dhcp.cox.net> ``` Hi, On Wed, 25 Jul 2007, Junio C Hamano wrote: > From: "Bradford C. Smith" > Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() > Date: Wed, 25 Jul 2007 12:49:53 -0400 > Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com> > > Changed git_commit_set_multivar() to use the routines provided by > lockfile.c to reduce code duplication and ensure consistent behavior. > > Signed-off-by: "Bradford C. Smith" > > Dscho, I think this is worth doing regardless of that "symlinked > config" issue. I haven't followed the code closely enough, > though. > > What do you think? I think that I will review it tomorrow; this darned work-tree stuff took way longer than expected. Ciao, Dscho ``` ## Johannes Schindelin, 2007-07-26 18:26 Subject: Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0707261926340.14781%40racer.site In-Reply-To: ``` Hi, On Thu, 26 Jul 2007, Bradford Smith wrote: > Dear Dscho, > > I've submitted a slightly modified version of the same patch to the list. > It fixes a comment format to match the approved style for git code. Please > review that one instead. I saw it and am reviewing it! Ciao, Dscho ```