threads / patch / 9222

patchgit-submodule: Error messages from 'git describe' shouldn't end up on the terminal

Subject: [PATCH] git-submodule: Error messages from 'git describe' shouldn't end up on the terminal

## tl;dr

2 messages between Jul 25, 2007 and Jul 25, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Emil Medve· Jul 25, 2007, 14:21 UTC · lore

As of now a failure to locate the closest tag to a commit (e.g because there is no tag in the repository) is handled explicitly by displaying an 'undefined' tag error message. However when git describe fails it will still display an undesirable "fatal: cannot describe SHA1" message. This patch hides that message as git-submodule has an alternative and explicit error handling method in place for this situation

Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-submodule.sh +1 −1

diff --git a/git-submodule.sh b/git-submodule.sh
index 1f0cb99..3804f18 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -233,7 +233,7 @@ modules_list()
 			say "-$sha1 $path"
 			continue;
 		fi
-		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
+		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1 2>/dev/null)
 		set_name_rev "$path" "$sha1"
 		if git diff-files --quiet -- "$path"
 		then

-- 
1.5.3.rc2.38.g11308-dirty

Junio C Hamano· Jul 25, 2007, 23:09 UTC · re: Emil Medve · lore

Re: [PATCH] git-submodule: Error messages from 'git describe' shouldn't end up on the terminal

Emil Medve <Emilian.Medve@Freescale.com> writes:

Show 25 quoted lines

> As of now a failure to locate the closest tag to a commit (e.g because there is
> no tag in the repository) is handled explicitly by displaying an 'undefined' tag
> error message. However when git describe fails it will still display an
> undesirable  "fatal: cannot describe SHA1" message. This patch hides that
> message as git-submodule has an alternative and explicit error handling method
> in place for this situation
>
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 1f0cb99..3804f18 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -233,7 +233,7 @@ modules_list()
>  			say "-$sha1 $path"
>  			continue;
>  		fi
> -		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> +		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1 2>/dev/null)
>  		set_name_rev "$path" "$sha1"
>  		if git diff-files --quiet -- "$path"
>  		then

It appears that set_name_rev does the moral equivalent of that line you touched but more elaborately, to set the same variable. Shouldn't we be simply removing that line instead?