# [PATCH] git-submodule: Error messages from 'git describe' shouldn't end up on the terminal 2 messages from 2007-07-25 to 2007-07-25. Participants: Emil Medve, Junio C Hamano. Thread: https://gitlist.dev/t/9222 ## Emil Medve, 2007-07-25 14:21 Subject: [PATCH] git-submodule: Error messages from 'git describe' shouldn't end up on the terminal Message-ID: <11853733111502-git-send-email-Emilian.Medve@Freescale.com> URL: https://gitlist.dev/e/11853733111502-git-send-email-Emilian.Medve%40Freescale.com ``` As of now a failure to locate the closest tag to a commit (e.g because there is no tag in the repository) is handled explicitly by displaying an 'undefined' tag error message. However when git describe fails it will still display an undesirable "fatal: cannot describe SHA1" message. This patch hides that message as git-submodule has an alternative and explicit error handling method in place for this situation Signed-off-by: Emil Medve --- git-submodule.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 1f0cb99..3804f18 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -233,7 +233,7 @@ modules_list() say "-$sha1 $path" continue; fi - revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1) + revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1 2>/dev/null) set_name_rev "$path" "$sha1" if git diff-files --quiet -- "$path" then -- 1.5.3.rc2.38.g11308-dirty ``` ## Junio C Hamano, 2007-07-25 23:09 Subject: Re: [PATCH] git-submodule: Error messages from 'git describe' shouldn't end up on the terminal Message-ID: <7vfy3ccc6y.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vfy3ccc6y.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <11853733111502-git-send-email-Emilian.Medve@Freescale.com> ``` Emil Medve writes: > As of now a failure to locate the closest tag to a commit (e.g because there is > no tag in the repository) is handled explicitly by displaying an 'undefined' tag > error message. However when git describe fails it will still display an > undesirable "fatal: cannot describe SHA1" message. This patch hides that > message as git-submodule has an alternative and explicit error handling method > in place for this situation > > Signed-off-by: Emil Medve > --- > git-submodule.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/git-submodule.sh b/git-submodule.sh > index 1f0cb99..3804f18 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -233,7 +233,7 @@ modules_list() > say "-$sha1 $path" > continue; > fi > - revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1) > + revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1 2>/dev/null) > set_name_rev "$path" "$sha1" > if git diff-files --quiet -- "$path" > then It appears that set_name_rev does the moral equivalent of that line you touched but more elaborately, to set the same variable. Shouldn't we be simply removing that line instead? ```