threads / patch / 9183

patch, 6 partsSome UI Improvements

Subject: [QGIT4 PATCH 0/6] Some UI Improvements

## tl;dr

10 messages between Jul 20, 2007 and Jul 24, 2007. Diffs are folded; open one to read it.

replies: 9people: 2as markdown or json

Peter Oberndorfer· Jul 23, 2007, 20:32 UTC · lore

Hi, the initial reason for this patches is that here on my system qgit4 looks like this http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png which is a bit suboptimal for viewing patches :-) this is on a standard qt 4.3 from gentoo

While i was there i removed the same problem in the custom action editor and removed some unneed empty space

Actually locally i removed even more empty space, like around the main tab view and inside the main tab view. If anyone wants me to remove that too, i would be happy to send more patches

[QGIT4 PATCH 1/6] update patchview.ui with new qt designer
	When i edit the .ui files with the QT designer it updates some unrelated parts.
	Because of this i split the update into a separate patch so the real changes are obvious.
	Feel free to collapse them if you want
[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
	this fixes the problem from the screenshot above
[QGIT4 PATCH 3/6] update patchview.ui with new qt designer
	same reason as patch 1
[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
	fix same problem in custom action editor
[QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
[QGIT4 PATCH 6/6] remove empty space below button bar in file view
	these remove some more empty space which i personally find useless
	Apply if you like them
If you want i can provide more screenshots of how patches change appearance.
Greetings Peter
Peter Oberndorfer· Jul 20, 2007, 20:50 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding

else the diff to header will take up half of the vertical space
Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
---
 src/patchview.ui |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Show changes to src/patchview.ui +6 −0
diff --git a/src/patchview.ui b/src/patchview.ui
index a599e09..6dbf53c 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -163,6 +163,12 @@
      </item>
      <item>
       <widget class="QSplitter" name="splitter_2" >
+       <property name="sizePolicy" >
+        <sizepolicy vsizetype="Expanding" hsizetype="Expanding" >
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
        <property name="orientation" >
         <enum>Qt::Horizontal</enum>
        </property>

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 20, 2007, 21:53 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view

---
 src/patchview.ui |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to src/patchview.ui +2 −2
diff --git a/src/patchview.ui b/src/patchview.ui
index 6dbf53c..b4d3081 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -31,7 +31,7 @@
    <item>
     <layout class="QVBoxLayout" >
      <property name="spacing" >
-      <number>6</number>
+      <number>0</number>
      </property>
      <property name="leftMargin" >
       <number>0</number>
@@ -131,7 +131,7 @@
          <property name="sizeHint" >
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>0</height>
           </size>
          </property>
         </spacer>

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 21, 2007, 13:22 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 6/6] remove empty space below button bar in file view

---
 src/fileview.ui |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to src/fileview.ui +1 −1
diff --git a/src/fileview.ui b/src/fileview.ui
index 190ed5e..97fa000 100644
--- a/src/fileview.ui
+++ b/src/fileview.ui
@@ -31,7 +31,7 @@
    <item>
     <layout class="QVBoxLayout" >
      <property name="spacing" >
-      <number>6</number>
+      <number>0</number>
      </property>
      <property name="leftMargin" >
       <number>0</number>

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 21, 2007, 13:24 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 3/6] update patchview.ui with new qt designer

---
 src/customaction.ui |  154 ++++++++++++++++++++++++++++++++++++++++-----------
 1 files changed, 121 insertions(+), 33 deletions(-)
Show changes to src/customaction.ui +121 −33
diff --git a/src/customaction.ui b/src/customaction.ui
index fc2ceba..59004ca 100644
--- a/src/customaction.ui
+++ b/src/customaction.ui
@@ -16,26 +16,42 @@
    <iconset resource="icons.qrc" >:/icons/resources/bookmark.png</iconset>
   </property>
   <layout class="QHBoxLayout" >
-   <property name="margin" >
-    <number>5</number>
-   </property>
    <property name="spacing" >
     <number>0</number>
    </property>
+   <property name="leftMargin" >
+    <number>5</number>
+   </property>
+   <property name="topMargin" >
+    <number>5</number>
+   </property>
+   <property name="rightMargin" >
+    <number>5</number>
+   </property>
+   <property name="bottomMargin" >
+    <number>5</number>
+   </property>
    <item>
     <layout class="QVBoxLayout" >
-     <property name="margin" >
-      <number>0</number>
-     </property>
      <property name="spacing" >
       <number>6</number>
      </property>
+     <property name="leftMargin" >
+      <number>0</number>
+     </property>
+     <property name="topMargin" >
+      <number>0</number>
+     </property>
+     <property name="rightMargin" >
+      <number>0</number>
+     </property>
+     <property name="bottomMargin" >
+      <number>0</number>
+     </property>
      <item>
       <widget class="QFrame" name="frame" >
        <property name="sizePolicy" >
-        <sizepolicy>
-         <hsizetype>5</hsizetype>
-         <vsizetype>0</vsizetype>
+        <sizepolicy vsizetype="Fixed" hsizetype="Preferred" >
          <horstretch>0</horstretch>
          <verstretch>0</verstretch>
         </sizepolicy>
@@ -47,20 +63,38 @@
         <enum>QFrame::Raised</enum>
        </property>
        <layout class="QHBoxLayout" >
-        <property name="margin" >
-         <number>9</number>
-        </property>
         <property name="spacing" >
          <number>6</number>
         </property>
+        <property name="leftMargin" >
+         <number>9</number>
+        </property>
+        <property name="topMargin" >
+         <number>9</number>
+        </property>
+        <property name="rightMargin" >
+         <number>9</number>
+        </property>
+        <property name="bottomMargin" >
+         <number>9</number>
+        </property>
         <item>
          <layout class="QHBoxLayout" >
-          <property name="margin" >
-           <number>0</number>
-          </property>
           <property name="spacing" >
            <number>15</number>
           </property>
+          <property name="leftMargin" >
+           <number>0</number>
+          </property>
+          <property name="topMargin" >
+           <number>0</number>
+          </property>
+          <property name="rightMargin" >
+           <number>0</number>
+          </property>
+          <property name="bottomMargin" >
+           <number>0</number>
+          </property>
           <item>
            <widget class="QPushButton" name="pushButtonNew" >
             <property name="text" >
@@ -147,20 +181,38 @@
          <enum>QFrame::Raised</enum>
         </property>
         <layout class="QHBoxLayout" >
-         <property name="margin" >
-          <number>9</number>
-         </property>
          <property name="spacing" >
           <number>6</number>
          </property>
+         <property name="leftMargin" >
+          <number>9</number>
+         </property>
+         <property name="topMargin" >
+          <number>9</number>
+         </property>
+         <property name="rightMargin" >
+          <number>9</number>
+         </property>
+         <property name="bottomMargin" >
+          <number>9</number>
+         </property>
          <item>
           <layout class="QVBoxLayout" >
-           <property name="margin" >
-            <number>0</number>
-           </property>
            <property name="spacing" >
             <number>6</number>
            </property>
+           <property name="leftMargin" >
+            <number>0</number>
+           </property>
+           <property name="topMargin" >
+            <number>0</number>
+           </property>
+           <property name="rightMargin" >
+            <number>0</number>
+           </property>
+           <property name="bottomMargin" >
+            <number>0</number>
+           </property>
            <item>
             <widget class="QLabel" name="labelActionName" >
              <property name="text" >
@@ -186,20 +238,38 @@
          <enum>QFrame::Raised</enum>
         </property>
         <layout class="QHBoxLayout" >
-         <property name="margin" >
-          <number>9</number>
-         </property>
          <property name="spacing" >
           <number>6</number>
          </property>
+         <property name="leftMargin" >
+          <number>9</number>
+         </property>
+         <property name="topMargin" >
+          <number>9</number>
+         </property>
+         <property name="rightMargin" >
+          <number>9</number>
+         </property>
+         <property name="bottomMargin" >
+          <number>9</number>
+         </property>
          <item>
           <layout class="QVBoxLayout" >
-           <property name="margin" >
-            <number>0</number>
-           </property>
            <property name="spacing" >
             <number>6</number>
            </property>
+           <property name="leftMargin" >
+            <number>0</number>
+           </property>
+           <property name="topMargin" >
+            <number>0</number>
+           </property>
+           <property name="rightMargin" >
+            <number>0</number>
+           </property>
+           <property name="bottomMargin" >
+            <number>0</number>
+           </property>
            <item>
             <widget class="QLabel" name="textLabel1" >
              <property name="text" >
@@ -219,12 +289,21 @@
            </item>
            <item>
             <layout class="QHBoxLayout" >
-             <property name="margin" >
-              <number>0</number>
-             </property>
              <property name="spacing" >
               <number>6</number>
              </property>
+             <property name="leftMargin" >
+              <number>0</number>
+             </property>
+             <property name="topMargin" >
+              <number>0</number>
+             </property>
+             <property name="rightMargin" >
+              <number>0</number>
+             </property>
+             <property name="bottomMargin" >
+              <number>0</number>
+             </property>
              <item>
               <widget class="QCheckBox" name="checkBoxRefreshAfterAction" >
                <property name="toolTip" >
@@ -261,12 +340,21 @@
      </item>
      <item>
       <layout class="QHBoxLayout" >
-       <property name="margin" >
-        <number>0</number>
-       </property>
        <property name="spacing" >
         <number>6</number>
        </property>
+       <property name="leftMargin" >
+        <number>0</number>
+       </property>
+       <property name="topMargin" >
+        <number>0</number>
+       </property>
+       <property name="rightMargin" >
+        <number>0</number>
+       </property>
+       <property name="bottomMargin" >
+        <number>0</number>
+       </property>
        <item>
         <spacer>
          <property name="orientation" >

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 21, 2007, 13:31 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox

in action setup dialog to expanding else the empty space with the button below takes up half of the vertical space

Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
---
 src/customaction.ui |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Show changes to src/customaction.ui +6 −0
diff --git a/src/customaction.ui b/src/customaction.ui
index 59004ca..49bb6c7 100644
--- a/src/customaction.ui
+++ b/src/customaction.ui
@@ -170,6 +170,12 @@
      </item>
      <item>
       <widget class="QSplitter" name="splitter" >
+       <property name="sizePolicy" >
+        <sizepolicy vsizetype="Expanding" hsizetype="Expanding" >
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
        <property name="orientation" >
         <enum>Qt::Horizontal</enum>
        </property>

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 22, 2007, 12:50 UTC · re: Peter Oberndorfer · lore

[QGIT4 PATCH 1/6] update patchview.ui with new qt designer

---
 src/patchview.ui |   57 ++++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 39 insertions(+), 18 deletions(-)
Show changes to src/patchview.ui +39 −18
diff --git a/src/patchview.ui b/src/patchview.ui
index 1539242..a599e09 100644
--- a/src/patchview.ui
+++ b/src/patchview.ui
@@ -13,28 +13,55 @@
    <string>Patch</string>
   </property>
   <layout class="QHBoxLayout" >
-   <property name="margin" >
+   <property name="spacing" >
     <number>0</number>
    </property>
-   <property name="spacing" >
+   <property name="leftMargin" >
+    <number>0</number>
+   </property>
+   <property name="topMargin" >
+    <number>0</number>
+   </property>
+   <property name="rightMargin" >
+    <number>0</number>
+   </property>
+   <property name="bottomMargin" >
     <number>0</number>
    </property>
    <item>
     <layout class="QVBoxLayout" >
-     <property name="margin" >
-      <number>0</number>
-     </property>
      <property name="spacing" >
       <number>6</number>
      </property>
+     <property name="leftMargin" >
+      <number>0</number>
+     </property>
+     <property name="topMargin" >
+      <number>0</number>
+     </property>
+     <property name="rightMargin" >
+      <number>0</number>
+     </property>
+     <property name="bottomMargin" >
+      <number>0</number>
+     </property>
      <item>
       <layout class="QHBoxLayout" >
-       <property name="margin" >
-        <number>2</number>
-       </property>
        <property name="spacing" >
         <number>6</number>
        </property>
+       <property name="leftMargin" >
+        <number>2</number>
+       </property>
+       <property name="topMargin" >
+        <number>2</number>
+       </property>
+       <property name="rightMargin" >
+        <number>2</number>
+       </property>
+       <property name="bottomMargin" >
+        <number>2</number>
+       </property>
        <item>
         <widget class="QLabel" name="textLabel" >
          <property name="text" >
@@ -112,9 +139,7 @@
        <item>
         <widget class="QLineEdit" name="lineEditDiff" >
          <property name="sizePolicy" >
-          <sizepolicy>
-           <hsizetype>7</hsizetype>
-           <vsizetype>0</vsizetype>
+          <sizepolicy vsizetype="Fixed" hsizetype="Expanding" >
            <horstretch>1</horstretch>
            <verstretch>0</verstretch>
           </sizepolicy>
@@ -143,9 +168,7 @@
        </property>
        <widget class="QSplitter" name="splitter" >
         <property name="sizePolicy" >
-         <sizepolicy>
-          <hsizetype>5</hsizetype>
-          <vsizetype>7</vsizetype>
+         <sizepolicy vsizetype="Expanding" hsizetype="Preferred" >
           <horstretch>5</horstretch>
           <verstretch>0</verstretch>
          </sizepolicy>
@@ -169,15 +192,13 @@
           <bool>true</bool>
          </property>
          <property name="textInteractionFlags" >
-          <enum>Qt::TextSelectableByMouse</enum>
+          <set>Qt::TextSelectableByMouse</set>
          </property>
         </widget>
        </widget>
        <widget class="FileList" name="fileList" >
         <property name="sizePolicy" >
-         <sizepolicy>
-          <hsizetype>13</hsizetype>
-          <vsizetype>13</vsizetype>
+         <sizepolicy vsizetype="Ignored" hsizetype="Ignored" >
           <horstretch>1</horstretch>
           <verstretch>0</verstretch>
          </sizepolicy>

-- 
1.5.3.rc2.30.g1fe72
Peter Oberndorfer· Jul 23, 2007, 20:52 UTC · re: Peter Oberndorfer · lore

Re: [QGIT4 PATCH 0/6] Some UI Improvements

On Monday 23 July 2007 22:32, Peter Oberndorfer wrote:
Show 41 quoted lines
> Hi,
> the initial reason for this patches is that here on my system qgit4 looks like this
> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
> which is a bit suboptimal for viewing patches :-)
> this is on a standard qt 4.3 from gentoo
> 
> While i was there i removed the same problem in the custom action editor
> and removed some unneed empty space
> 
> Actually locally i removed even more empty space, like around the main tab view
> and inside the main tab view.
> If anyone wants me to remove that too, i would be happy to send more patches
> 
> [QGIT4 PATCH 1/6] update patchview.ui with new qt designer
> 	When i edit the .ui files with the QT designer it updates some unrelated parts.
> 	Because of this i split the update into a separate patch so the real changes are obvious.
> 	Feel free to collapse them if you want
> 
> [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
> 	this fixes the problem from the screenshot above
> 
> [QGIT4 PATCH 3/6] update patchview.ui with new qt designer
> 	same reason as patch 1
> 
> [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
> 	fix same problem in custom action editor
> 
> [QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
> [QGIT4 PATCH 6/6] remove empty space below button bar in file view
> 	these remove some more empty space which i personally find useless
> 	Apply if you like them
> 
> If you want i can provide more screenshots of how patches change appearance.
> 
> Greetings Peter
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>

hmm, kmail moved Signed-off-by in patches to mail headers, because there was no message text before it.

so here is a
Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
for all my qgit patches
Greetings Peter
Marco Costalba· Jul 23, 2007, 22:13 UTC · re: Peter Oberndorfer · lore

Re: [QGIT4 PATCH 0/6] Some UI Improvements

On 7/23/07, Peter Oberndorfer <kumbayo84@arcor.de> wrote:
> Hi,
> the initial reason for this patches is that here on my system qgit4 looks like this
> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
Hi Peter,

OMG that's horrific! I can't understand how it is possible, on my box (Mandriva with QT4.3) everything is fine.

Anyway thanks a lot for the patches. Already applied and pushed.
 > If anyone wants me to remove that too, i would be happy to send more patches

Please feel free to send me any patch that could improve the GUI, unfortunately on my box I'm unable to see all these defects, so any patch from you is more then welcome.

>
> If you want i can provide more screenshots of how patches change appearance.
>

Patchview has not changed for me with your patches, fileview yes, I can see the difference and also customaction. I would say nice job! thanks.

 Marco
Peter Oberndorfer· Jul 24, 2007, 17:29 UTC · re: Marco Costalba · lore

Re: [QGIT4 PATCH 0/6] Some UI Improvements

On Tuesday 24 July 2007 00:13, Marco Costalba wrote:
Show 11 quoted lines
> On 7/23/07, Peter Oberndorfer <kumbayo84@arcor.de> wrote:
> > Hi,
> > the initial reason for this patches is that here on my system qgit4 looks like this
> > http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
> 
> Hi Peter,
> 
> OMG that's horrific! I can't understand how it is possible, on my box
> (Mandriva with QT4.3) everything is fine.
> 
> Anyway thanks a lot for the patches. Already applied and pushed.
Thanks for applying.
Show 6 quoted lines
> 
>  > If anyone wants me to remove that too, i would be happy to send more patches
> 
> Please feel free to send me any patch that could improve the GUI,
> unfortunately on my box I'm unable to see all these defects, so any
> patch from you is more then welcome.
Will send them when they are cleaned up properly.
Show 8 quoted lines
> 
> >
> > If you want i can provide more screenshots of how patches change appearance.
> >
> 
> Patchview has not changed for me with your patches, fileview yes, I
> can see the difference and also customaction. I would say nice job!
> thanks.

Without patch 5 (remove empty space below "diff to" header in patch view) qgit4 looks like this on my machine http://img409.imageshack.us/img409/5174/qgitwithoutpatch5zp9.png

Greetings Peter
Show 8 quoted lines
> 
>  Marco
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>

← back to recent threads