{"thread":{"id":"9183","subject":"[QGIT4 PATCH 0/6] Some UI Improvements","startedAt":"2007-07-20T20:50:10Z","lastAt":"2007-07-24T17:29:36Z","messageCount":10,"participants":["Peter Oberndorfer","Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"48348","messageId":"20070723204317.5A7F628ABA1@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-20T20:50:10Z","receivedAt":"2007-07-20T20:50:10Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"else the diff to header will take up half of the vertical space\n\nSigned-off-by: Peter Oberndorfer \n---\n src/patchview.ui | 6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/src/patchview.ui b/src/patchview.ui\nindex a599e09..6dbf53c 100644\n--- a/src/patchview.ui\n+++ b/src/patchview.ui\n@@ -163,6 +163,12 @@\n \n \n \n+ \n+ \n+ 0\n+ 0\n+ \n+ \n \n Qt::Horizontal\n \n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48349","messageId":"20070723204323.5DC9C28ABA1@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 5/6] remove empty space below \"diff to\" header in patch view","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-20T21:53:15Z","receivedAt":"2007-07-20T21:53:15Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"---\n src/patchview.ui | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/src/patchview.ui b/src/patchview.ui\nindex 6dbf53c..b4d3081 100644\n--- a/src/patchview.ui\n+++ b/src/patchview.ui\n@@ -31,7 +31,7 @@\n \n \n \n- 6\n+ 0\n \n \n 0\n@@ -131,7 +131,7 @@\n \n \n 20\n- 40\n+ 0\n \n \n \n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48352","messageId":"20070723204323.A8F4828ABA1@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 6/6] remove empty space below button bar in file view","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-21T13:22:42Z","receivedAt":"2007-07-21T13:22:42Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"---\n src/fileview.ui | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/src/fileview.ui b/src/fileview.ui\nindex 190ed5e..97fa000 100644\n--- a/src/fileview.ui\n+++ b/src/fileview.ui\n@@ -31,7 +31,7 @@\n \n \n \n- 6\n+ 0\n \n \n 0\n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48351","messageId":"20070723204322.A12C028ABA1@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 3/6] update patchview.ui with new qt designer","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-21T13:24:13Z","receivedAt":"2007-07-21T13:24:13Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"---\n src/customaction.ui | 154 ++++++++++++++++++++++++++++++++++++++++-----------\n 1 files changed, 121 insertions(+), 33 deletions(-)\n\ndiff --git a/src/customaction.ui b/src/customaction.ui\nindex fc2ceba..59004ca 100644\n--- a/src/customaction.ui\n+++ b/src/customaction.ui\n@@ -16,26 +16,42 @@\n :/icons/resources/bookmark.png\n \n \n- \n- 5\n- \n \n 0\n \n+ \n+ 5\n+ \n+ \n+ 5\n+ \n+ \n+ 5\n+ \n+ \n+ 5\n+ \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n- \n- 5\n- 0\n+ \n 0\n 0\n \n@@ -47,20 +63,38 @@\n QFrame::Raised\n \n \n- \n- 9\n- \n \n 6\n \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n \n \n- \n- 0\n- \n \n 15\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n@@ -147,20 +181,38 @@\n QFrame::Raised\n \n \n- \n- 9\n- \n \n 6\n \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n@@ -186,20 +238,38 @@\n QFrame::Raised\n \n \n- \n- 9\n- \n \n 6\n \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n+ \n+ 9\n+ \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n@@ -219,12 +289,21 @@\n \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n@@ -261,12 +340,21 @@\n \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n \n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48350","messageId":"20070723204323.0DE8828ABA2@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-21T13:31:03Z","receivedAt":"2007-07-21T13:31:03Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"in action setup dialog to expanding\nelse the empty space with the button below takes up half of the vertical space\n\nSigned-off-by: Peter Oberndorfer \n---\n src/customaction.ui | 6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/src/customaction.ui b/src/customaction.ui\nindex 59004ca..49bb6c7 100644\n--- a/src/customaction.ui\n+++ b/src/customaction.ui\n@@ -170,6 +170,12 @@\n \n \n \n+ \n+ \n+ 0\n+ 0\n+ \n+ \n \n Qt::Horizontal\n \n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48347","messageId":"20070723204317.074D528ABA1@mail-in-07.arcor-online.net","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"[QGIT4 PATCH 1/6] update patchview.ui with new qt designer","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-22T12:50:47Z","receivedAt":"2007-07-22T12:50:47Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"---\n src/patchview.ui | 57 ++++++++++++++++++++++++++++++++++++-----------------\n 1 files changed, 39 insertions(+), 18 deletions(-)\n\ndiff --git a/src/patchview.ui b/src/patchview.ui\nindex 1539242..a599e09 100644\n--- a/src/patchview.ui\n+++ b/src/patchview.ui\n@@ -13,28 +13,55 @@\n Patch\n \n \n- \n+ \n 0\n \n- \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n 0\n \n \n \n- \n- 0\n- \n \n 6\n \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n+ \n+ 0\n+ \n \n \n- \n- 2\n- \n \n 6\n \n+ \n+ 2\n+ \n+ \n+ 2\n+ \n+ \n+ 2\n+ \n+ \n+ 2\n+ \n \n \n \n@@ -112,9 +139,7 @@\n \n \n \n- \n- 7\n- 0\n+ \n 1\n 0\n \n@@ -143,9 +168,7 @@\n \n \n \n- \n- 5\n- 7\n+ \n 5\n 0\n \n@@ -169,15 +192,13 @@\n true\n \n \n- Qt::TextSelectableByMouse\n+ Qt::TextSelectableByMouse\n \n \n \n \n \n- \n- 13\n- 13\n+ \n 1\n 0\n \n-- \n1.5.3.rc2.30.g1fe72\n"},{"id":"48346","messageId":"200707232232.39546.kumbayo84@arcor.de","threadId":"9183","inReplyTo":null,"subject":"[QGIT4 PATCH 0/6] Some UI Improvements","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-23T20:32:39Z","receivedAt":"2007-07-23T20:32:39Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"Hi,\nthe initial reason for this patches is that here on my system qgit4 looks like this\nhttp://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png\nwhich is a bit suboptimal for viewing patches :-)\nthis is on a standard qt 4.3 from gentoo\n\nWhile i was there i removed the same problem in the custom action editor\nand removed some unneed empty space\n\nActually locally i removed even more empty space, like around the main tab view\nand inside the main tab view.\nIf anyone wants me to remove that too, i would be happy to send more patches\n\n[QGIT4 PATCH 1/6] update patchview.ui with new qt designer\n\tWhen i edit the .ui files with the QT designer it updates some unrelated parts.\n\tBecause of this i split the update into a separate patch so the real changes are obvious.\n\tFeel free to collapse them if you want\n\n[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding\n\tthis fixes the problem from the screenshot above\n\n[QGIT4 PATCH 3/6] update patchview.ui with new qt designer\n\tsame reason as patch 1\n\n[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox\n\tfix same problem in custom action editor\n\n[QGIT4 PATCH 5/6] remove empty space below \"diff to\" header in patch view\n[QGIT4 PATCH 6/6] remove empty space below button bar in file view\n\tthese remove some more empty space which i personally find useless\n\tApply if you like them\n\nIf you want i can provide more screenshots of how patches change appearance.\n\nGreetings Peter\n"},{"id":"48356","messageId":"200707232252.39456.kumbayo84@arcor.de","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"Re: [QGIT4 PATCH 0/6] Some UI Improvements","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-23T20:52:38Z","receivedAt":"2007-07-23T20:52:38Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"On Monday 23 July 2007 22:32, Peter Oberndorfer wrote:\n> Hi,\n> the initial reason for this patches is that here on my system qgit4 looks like this\n> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png\n> which is a bit suboptimal for viewing patches :-)\n> this is on a standard qt 4.3 from gentoo\n> \n> While i was there i removed the same problem in the custom action editor\n> and removed some unneed empty space\n> \n> Actually locally i removed even more empty space, like around the main tab view\n> and inside the main tab view.\n> If anyone wants me to remove that too, i would be happy to send more patches\n> \n> [QGIT4 PATCH 1/6] update patchview.ui with new qt designer\n> \tWhen i edit the .ui files with the QT designer it updates some unrelated parts.\n> \tBecause of this i split the update into a separate patch so the real changes are obvious.\n> \tFeel free to collapse them if you want\n> \n> [QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding\n> \tthis fixes the problem from the screenshot above\n> \n> [QGIT4 PATCH 3/6] update patchview.ui with new qt designer\n> \tsame reason as patch 1\n> \n> [QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox\n> \tfix same problem in custom action editor\n> \n> [QGIT4 PATCH 5/6] remove empty space below \"diff to\" header in patch view\n> [QGIT4 PATCH 6/6] remove empty space below button bar in file view\n> \tthese remove some more empty space which i personally find useless\n> \tApply if you like them\n> \n> If you want i can provide more screenshots of how patches change appearance.\n> \n> Greetings Peter\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n> \nhmm, kmail moved Signed-off-by in patches to mail headers,\nbecause there was no message text before it.\n\nso here is a\nSigned-off-by: Peter Oberndorfer \nfor all my qgit patches\n\nGreetings Peter\n"},{"id":"48363","messageId":"e5bfff550707231513u8568e48hb280151b8f40681c@mail.gmail.com","threadId":"9183","inReplyTo":"200707232232.39546.kumbayo84@arcor.de","subject":"Re: [QGIT4 PATCH 0/6] Some UI Improvements","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-07-23T22:13:04Z","receivedAt":"2007-07-23T22:13:04Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 7/23/07, Peter Oberndorfer wrote:\n> Hi,\n> the initial reason for this patches is that here on my system qgit4 looks like this\n> http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png\n\nHi Peter,\n\nOMG that's horrific! I can't understand how it is possible, on my box\n(Mandriva with QT4.3) everything is fine.\n\nAnyway thanks a lot for the patches. Already applied and pushed.\n\n > If anyone wants me to remove that too, i would be happy to send more patches\n\nPlease feel free to send me any patch that could improve the GUI,\nunfortunately on my box I'm unable to see all these defects, so any\npatch from you is more then welcome.\n\n>\n> If you want i can provide more screenshots of how patches change appearance.\n>\n\nPatchview has not changed for me with your patches, fileview yes, I\ncan see the difference and also customaction. I would say nice job!\nthanks.\n\n Marco\n"},{"id":"48488","messageId":"200707241929.36782.kumbayo84@arcor.de","threadId":"9183","inReplyTo":"e5bfff550707231513u8568e48hb280151b8f40681c@mail.gmail.com","subject":"Re: [QGIT4 PATCH 0/6] Some UI Improvements","fromName":"Peter Oberndorfer","fromEmail":"kumbayo84@arcor.de","sentAt":"2007-07-24T17:29:36Z","receivedAt":"2007-07-24T17:29:36Z","isPatch":true,"sender":{"key":"kumbayo84@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1041267?v=4"},"body":"On Tuesday 24 July 2007 00:13, Marco Costalba wrote:\n> On 7/23/07, Peter Oberndorfer wrote:\n> > Hi,\n> > the initial reason for this patches is that here on my system qgit4 looks like this\n> > http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png\n> \n> Hi Peter,\n> \n> OMG that's horrific! I can't understand how it is possible, on my box\n> (Mandriva with QT4.3) everything is fine.\n> \n> Anyway thanks a lot for the patches. Already applied and pushed.\nThanks for applying.\n> \n> > If anyone wants me to remove that too, i would be happy to send more patches\n> \n> Please feel free to send me any patch that could improve the GUI,\n> unfortunately on my box I'm unable to see all these defects, so any\n> patch from you is more then welcome.\nWill send them when they are cleaned up properly.\n> \n> >\n> > If you want i can provide more screenshots of how patches change appearance.\n> >\n> \n> Patchview has not changed for me with your patches, fileview yes, I\n> can see the difference and also customaction. I would say nice job!\n> thanks.\nWithout patch 5 (remove empty space below \"diff to\" header in patch view)\nqgit4 looks like this on my machine\nhttp://img409.imageshack.us/img409/5174/qgitwithoutpatch5zp9.png\n\nGreetings Peter\n> \n> Marco\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n> \n"}]}