threads / patch / 916

patchcg-Xlib: make showdate show timezone

Subject: [PATCH] cg-Xlib: make showdate show timezone

## tl;dr

3 messages between Jun 12, 2005 and Jun 12, 2005. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Dan Holmsand· Jun 12, 2005, 11:40 UTC · lore

This makes timezones show up again in showdate's default format. Hopefully, this also makes showdate a little more portable.

It also speeds things up a little, by avoiding an extra fork.

Signed-off-by: Dan Holmsand <holmsand@gmail.com>
---

 cg-Xlib |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

Show changes to cg-Xlib +3 −5

diff --git a/cg-Xlib b/cg-Xlib
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -68,14 +68,12 @@ showdate () {
 	# bash doesn't like leading zeros
 	[ "${tzhours:1:1}" = 0 ] && tzhours=${2:0:1}${2:2:1}
 	secs=$(($secs + $tzhours * 3600 + $tzmins * 60))
+	[ "$format" ] || format="+%a, %d %b %Y %H:%M:%S $2"
 	if [ "$has_gnudate" ]; then
-		[ "$format" ] || format=-R
-		pdate=$(date -ud "1970-01-01 UTC + $secs sec" "$format")
+		LANG=C date -ud "1970-01-01 UTC + $secs sec" "$format"
 	else
-		[ "$format" ] || format=--
-		pdate=$(date -u -r $secs "$format")
+		LANG=C date -u -r $secs "$format"
 	fi
-	echo "${pdate/+0000/$tz}"
 }
 
 # Usage: tree_timewarp [--no-head-update] DIRECTION_STR ROLLBACK_BOOL BASE BRANCH

Petr Baudis· Jun 12, 2005, 11:52 UTC · re: Dan Holmsand · lore

Re: [PATCH] cg-Xlib: make showdate show timezone

Dear diary, on Sun, Jun 12, 2005 at 01:40:57PM CEST, I got a letter where Dan Holmsand <holmsand@gmail.com> told me that...

Show 7 quoted lines

> This makes timezones show up again in showdate's default
> format. Hopefully, this also makes showdate a little more
> portable.
> 
> It also speeds things up a little, by avoiding an extra fork.
> 
> Signed-off-by: Dan Holmsand <holmsand@gmail.com>

Thanks, applied. But what's the point of calling date with LANG=C? If the user wants his locale to get used, why prevent him?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..

Dan Holmsand· Jun 12, 2005, 17:37 UTC · re: Petr Baudis · lore

Re: [PATCH] cg-Xlib: make showdate show timezone

Petr Baudis wrote:

> Thanks, applied. But what's the point of calling date with LANG=C? If
> the user wants his locale to get used, why prevent him?

Because otherwise, you won't get an RFC-2822 date (which is what you explicitly wanted a couple of days ago, and what we had before).

Also, it would look pretty awkward to have parts of the output localized 
  (the date string), and all other parts not ("author", "date", whatnot).

/dan