# [PATCH] cg-Xlib: make showdate show timezone 3 messages from 2005-06-12 to 2005-06-12. Participants: Dan Holmsand, Petr Baudis. Thread: https://gitlist.dev/t/916 ## Dan Holmsand, 2005-06-12 11:40 Subject: [PATCH] cg-Xlib: make showdate show timezone Message-ID: <42AC1F49.9010808@gmail.com> URL: https://gitlist.dev/e/42AC1F49.9010808%40gmail.com ``` This makes timezones show up again in showdate's default format. Hopefully, this also makes showdate a little more portable. It also speeds things up a little, by avoiding an extra fork. Signed-off-by: Dan Holmsand --- cg-Xlib | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/cg-Xlib b/cg-Xlib --- a/cg-Xlib +++ b/cg-Xlib @@ -68,14 +68,12 @@ showdate () { # bash doesn't like leading zeros [ "${tzhours:1:1}" = 0 ] && tzhours=${2:0:1}${2:2:1} secs=$(($secs + $tzhours * 3600 + $tzmins * 60)) + [ "$format" ] || format="+%a, %d %b %Y %H:%M:%S $2" if [ "$has_gnudate" ]; then - [ "$format" ] || format=-R - pdate=$(date -ud "1970-01-01 UTC + $secs sec" "$format") + LANG=C date -ud "1970-01-01 UTC + $secs sec" "$format" else - [ "$format" ] || format=-- - pdate=$(date -u -r $secs "$format") + LANG=C date -u -r $secs "$format" fi - echo "${pdate/+0000/$tz}" } # Usage: tree_timewarp [--no-head-update] DIRECTION_STR ROLLBACK_BOOL BASE BRANCH ``` ## Petr Baudis, 2005-06-12 11:52 Subject: Re: [PATCH] cg-Xlib: make showdate show timezone Message-ID: <20050612115259.GD6620@pasky.ji.cz> URL: https://gitlist.dev/e/20050612115259.GD6620%40pasky.ji.cz In-Reply-To: <42AC1F49.9010808@gmail.com> ``` Dear diary, on Sun, Jun 12, 2005 at 01:40:57PM CEST, I got a letter where Dan Holmsand told me that... > This makes timezones show up again in showdate's default > format. Hopefully, this also makes showdate a little more > portable. > > It also speeds things up a little, by avoiding an extra fork. > > Signed-off-by: Dan Holmsand Thanks, applied. But what's the point of calling date with LANG=C? If the user wants his locale to get used, why prevent him? -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ be careful, some twit might quote you out of context.. ``` ## Dan Holmsand, 2005-06-12 17:37 Subject: Re: [PATCH] cg-Xlib: make showdate show timezone Message-ID: <42AC72C2.8000807@gmail.com> URL: https://gitlist.dev/e/42AC72C2.8000807%40gmail.com In-Reply-To: <20050612115259.GD6620@pasky.ji.cz> ``` Petr Baudis wrote: > Thanks, applied. But what's the point of calling date with LANG=C? If > the user wants his locale to get used, why prevent him? Because otherwise, you won't get an RFC-2822 date (which is what you explicitly wanted a couple of days ago, and what we had before). Also, it would look pretty awkward to have parts of the output localized (the date string), and all other parts not ("author", "date", whatnot). /dan ```