threads / patch / 9135

patchFix update-po target to call msgmerge with right parameters

Subject: [PATCH] Fix update-po target to call msgmerge with right parameters

## tl;dr

2 messages between Jul 22, 2007 and Jul 22, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Alex Riesen· Jul 22, 2007, 10:19 UTC · lore

Add accidentally forgotten semicolon at the end of msgmerge command line
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 52975a7..2c9b3ad 100644
--- a/Makefile
+++ b/Makefile
@@ -113,7 +113,7 @@ ALL_MSGFILES = $(subst .po,.msg,$(ALL_POFILES))
 $(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES)
 	$(XGETTEXT) -kmc -LTcl -o $@ $(SCRIPT_SH) $(ALL_LIBFILES)
 update-po:: $(PO_TEMPLATE)
-	$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) )
+	$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )
 $(ALL_MSGFILES): %.msg : %.po
 	@echo Generating catalog $@
 	msgfmt --statistics --tcl $< -l $(basename $(notdir $<)) -d $(dir $@)

-- 
1.5.3.rc2.37.g67fa

Johannes Schindelin· Jul 22, 2007, 11:48 UTC · re: Alex Riesen · lore

Re: [PATCH] Fix update-po target to call msgmerge with right parameters

Hi,

On Sun, 22 Jul 2007, Alex Riesen wrote:

> Add accidentally forgotten semicolon at the end of msgmerge command line

Good catch!

I did a "make update-po" to test before and after your patch. There seem to be some changes, but the worst part of it: update-po rewrites almost the whole file! The .po files contain the line numbers where the message was found, and they often change.

Oh, well. I'll probably write some alias to see what _actually_ changed (probably just ignoring ^#)...

Ciao, Dscho