# [PATCH] Fix update-po target to call msgmerge with right parameters

2 messages from 2007-07-22 to 2007-07-22. Participants: Alex Riesen, Johannes Schindelin.
Thread: https://gitlist.dev/t/9135

## Alex Riesen, 2007-07-22 10:19

Subject: [PATCH] Fix update-po target to call msgmerge with right parameters
Message-ID: <20070722101930.GC3408@steel.home>
URL: https://gitlist.dev/e/20070722101930.GC3408%40steel.home

```
Add accidentally forgotten semicolon at the end of msgmerge command line
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 52975a7..2c9b3ad 100644
--- a/Makefile
+++ b/Makefile
@@ -113,7 +113,7 @@ ALL_MSGFILES = $(subst .po,.msg,$(ALL_POFILES))
 $(PO_TEMPLATE): $(SCRIPT_SH) $(ALL_LIBFILES)
 	$(XGETTEXT) -kmc -LTcl -o $@ $(SCRIPT_SH) $(ALL_LIBFILES)
 update-po:: $(PO_TEMPLATE)
-	$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) )
+	$(foreach p, $(ALL_POFILES), echo Updating $p ; msgmerge -U $p $(PO_TEMPLATE) ; )
 $(ALL_MSGFILES): %.msg : %.po
 	@echo Generating catalog $@
 	msgfmt --statistics --tcl $< -l $(basename $(notdir $<)) -d $(dir $@)
-- 
1.5.3.rc2.37.g67fa

```

## Johannes Schindelin, 2007-07-22 11:48

Subject: Re: [PATCH] Fix update-po target to call msgmerge with right parameters
Message-ID: <Pine.LNX.4.64.0707221246040.14781@racer.site>
URL: https://gitlist.dev/e/Pine.LNX.4.64.0707221246040.14781%40racer.site
In-Reply-To: <20070722101930.GC3408@steel.home>

```
Hi,

On Sun, 22 Jul 2007, Alex Riesen wrote:

> Add accidentally forgotten semicolon at the end of msgmerge command line

Good catch!

I did a "make update-po" to test before and after your patch.  There seem 
to be some changes, but the worst part of it: update-po rewrites almost 
the whole file!  The .po files contain the line numbers where the message 
was found, and they often change.

Oh, well.  I'll probably write some alias to see what _actually_ 
changed (probably just ignoring ^#)...

Ciao,
Dscho

```