[PATCH] Unquote From line from patch before comparing with given from address.

Kristian Høgsberg· Jun 11, 2007, 17:04 UTC · lore

This makes --suppress-from actually work when you're unfortunate enough to have non-ASCII in your name. Also, if there's a match use the optionally RFC2047 quoted version from the email.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---
 git-send-email.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Show changes to git-send-email.perl +2 −1

diff --git a/git-send-email.perl b/git-send-email.perl
index eb876f8..7c0c90b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -561,7 +561,8 @@ foreach my $t (@files) {
 					$subject = $1;
 
 				} elsif (/^(Cc|From):\s+(.*)$/) {
-					if ($2 eq $from) {
+					if (unquote_rfc2047($2) eq $from) {
+						$from = $2;
 						next if ($suppress_from);
 					}
 					elsif ($1 eq 'From') {

-- 
1.5.2.GIT

Junio C Hamano· Jun 12, 2007, 05:28 UTC · re: Kristian Høgsberg · lore

Re: [PATCH] Unquote From line from patch before comparing with given from address.

Thanks.

That has been longstanding, and I hinted how that can be fixed a couple of times on the list, and was waiting for somebody for whom fixing it would make a difference to fix it, while sort of pretending to be lazy.

Happy to see finally somebody stepped forward ;-).

patchUnquote From line from patch before comparing with given from address.