# [PATCH] Unquote From line from patch before comparing with given from address.

2 messages from 2007-06-11 to 2007-06-12. Participants: Kristian Høgsberg, Junio C Hamano.
Thread: https://gitlist.dev/t/8559

## Kristian Høgsberg, 2007-06-11 17:04

Subject: [PATCH] Unquote From line from patch before comparing with given from address.
Message-ID: <11815814802456-git-send-email-krh@redhat.com>
URL: https://gitlist.dev/e/11815814802456-git-send-email-krh%40redhat.com

```
This makes --suppress-from actually work when you're unfortunate enough
to have non-ASCII in your name.  Also, if there's a match use the optionally
RFC2047 quoted version from the email.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---
 git-send-email.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index eb876f8..7c0c90b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -561,7 +561,8 @@ foreach my $t (@files) {
 					$subject = $1;
 
 				} elsif (/^(Cc|From):\s+(.*)$/) {
-					if ($2 eq $from) {
+					if (unquote_rfc2047($2) eq $from) {
+						$from = $2;
 						next if ($suppress_from);
 					}
 					elsif ($1 eq 'From') {
-- 
1.5.2.GIT

```

## Junio C Hamano, 2007-06-12 05:28

Subject: Re: [PATCH] Unquote From line from patch before comparing with given from address.
Message-ID: <7v4pldn3ma.fsf@assigned-by-dhcp.pobox.com>
URL: https://gitlist.dev/e/7v4pldn3ma.fsf%40assigned-by-dhcp.pobox.com
In-Reply-To: <11815814802456-git-send-email-krh@redhat.com>

```
Thanks.

That has been longstanding, and I hinted how that can be fixed a
couple of times on the list, and was waiting for somebody for
whom fixing it would make a difference to fix it, while sort of
pretending to be lazy.

Happy to see finally somebody stepped forward ;-).

```