threads / patch / 7714

patchgit-svn: quiet some warnings when run only with --version/--help

Subject: [PATCH] git-svn: quiet some warnings when run only with --version/--help

## tl;dr

3 messages between Apr 17, 2007 and Apr 17, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Eric Wong· Apr 17, 2007, 09:41 UTC · lore

These are harmless but annoying. They were introduced in 512b620bd9fef7f170562ecad835e37479f051ce

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---

 Junio: did you miss
 http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?

 Thanks,

 git-svn.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to git-svn.perl +2 −2

diff --git a/git-svn.perl b/git-svn.perl
index eb3b79c..d2a5fe4 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -168,14 +168,14 @@ for (my $i = 0; $i < @ARGV; $i++) {
 my %opts = %{$cmd{$cmd}->[2]} if (defined $cmd);
 
 read_repo_config(\%opts);
-Getopt::Long::Configure('pass_through') if $cmd eq 'log';
+Getopt::Long::Configure('pass_through') if ($cmd && $cmd eq 'log');
 my $rv = GetOptions(%opts, 'help|H|h' => \$_help, 'version|V' => \$_version,
                     'minimize-connections' => \$Git::SVN::Migration::_minimize,
                     'id|i=s' => \$Git::SVN::default_ref_id,
                     'svn-remote|remote|R=s' => sub {
                        $Git::SVN::no_reuse_existing = 1;
                        $Git::SVN::default_repo_id = $_[1] });
-exit 1 if (!$rv && $cmd ne 'log');
+exit 1 if (!$rv && $cmd && $cmd ne 'log');
 
 usage(0) if $_help;
 version() if $_version;

-- 
Eric Wong

Junio C Hamano· Apr 17, 2007, 09:46 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: quiet some warnings when run only with --version/--help

Eric Wong <normalperson@yhbt.net> writes:

Show 8 quoted lines

> These are harmless but annoying.  They were introduced in
> 512b620bd9fef7f170562ecad835e37479f051ce
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>
>  Junio: did you miss
>  http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?

Indeed.  Are these two 'maint' material?

Eric Wong· Apr 17, 2007, 10:28 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-svn: quiet some warnings when run only with --version/--help

Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> Eric Wong <normalperson@yhbt.net> writes:
> 
> > These are harmless but annoying.  They were introduced in
> > 512b620bd9fef7f170562ecad835e37479f051ce
> >
> > Signed-off-by: Eric Wong <normalperson@yhbt.net>
> > ---
> >
> >  Junio: did you miss
> >  http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?
> 
> Indeed.  Are these two 'maint' material?

Yes.  Definitely so.

-- 
Eric Wong