{"thread":{"id":"7714","subject":"[PATCH] git-svn: quiet some warnings when run only with --version/--help","startedAt":"2007-04-17T09:41:43Z","lastAt":"2007-04-17T10:28:18Z","messageCount":3,"participants":["Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"39627","messageId":"20070417094143.GB2778@muzzle","threadId":"7714","inReplyTo":null,"subject":"[PATCH] git-svn: quiet some warnings when run only with --version/--help","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-04-17T09:41:43Z","receivedAt":"2007-04-17T09:41:43Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"These are harmless but annoying.  They were introduced in\n512b620bd9fef7f170562ecad835e37479f051ce\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n\n Junio: did you miss\n http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?\n\n Thanks,\n\n git-svn.perl |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex eb3b79c..d2a5fe4 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -168,14 +168,14 @@ for (my $i = 0; $i < @ARGV; $i++) {\n my %opts = %{$cmd{$cmd}->[2]} if (defined $cmd);\n \n read_repo_config(\\%opts);\n-Getopt::Long::Configure('pass_through') if $cmd eq 'log';\n+Getopt::Long::Configure('pass_through') if ($cmd && $cmd eq 'log');\n my $rv = GetOptions(%opts, 'help|H|h' => \\$_help, 'version|V' => \\$_version,\n                     'minimize-connections' => \\$Git::SVN::Migration::_minimize,\n                     'id|i=s' => \\$Git::SVN::default_ref_id,\n                     'svn-remote|remote|R=s' => sub {\n                        $Git::SVN::no_reuse_existing = 1;\n                        $Git::SVN::default_repo_id = $_[1] });\n-exit 1 if (!$rv && $cmd ne 'log');\n+exit 1 if (!$rv && $cmd && $cmd ne 'log');\n \n usage(0) if $_help;\n version() if $_version;\n\n-- \nEric Wong\n"},{"id":"39630","messageId":"7vvefvpc3b.fsf@assigned-by-dhcp.cox.net","threadId":"7714","inReplyTo":"20070417094143.GB2778@muzzle","subject":"Re: [PATCH] git-svn: quiet some warnings when run only with --version/--help","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-17T09:46:48Z","receivedAt":"2007-04-17T09:46:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong <normalperson@yhbt.net> writes:\n\n> These are harmless but annoying.  They were introduced in\n> 512b620bd9fef7f170562ecad835e37479f051ce\n>\n> Signed-off-by: Eric Wong <normalperson@yhbt.net>\n> ---\n>\n>  Junio: did you miss\n>  http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?\n\nIndeed.  Are these two 'maint' material?\n"},{"id":"39635","messageId":"20070417102818.GA20984@hand.yhbt.net","threadId":"7714","inReplyTo":"7vvefvpc3b.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] git-svn: quiet some warnings when run only with --version/--help","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-04-17T10:28:18Z","receivedAt":"2007-04-17T10:28:18Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano <junkio@cox.net> wrote:\n> Eric Wong <normalperson@yhbt.net> writes:\n> \n> > These are harmless but annoying.  They were introduced in\n> > 512b620bd9fef7f170562ecad835e37479f051ce\n> >\n> > Signed-off-by: Eric Wong <normalperson@yhbt.net>\n> > ---\n> >\n> >  Junio: did you miss\n> >  http://permalink.gmane.org/gmane.comp.version-control.git/44493 ?\n> \n> Indeed.  Are these two 'maint' material?\n\nYes.  Definitely so.\n\n-- \nEric Wong\n"}]}