[gitweb PATCH] Kill warnings in Webserver Error Log

Jochen Roemling· May 30, 2005, 19:34 UTC · lore

The following patch kills two warnings in the Web Server Error Log:

[Mon May 30 21:24:15 2005] gitweb.cgi: "my" variable %co masks earlier declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi line 1658. [Mon May 30 21:25:46 2005] gitweb.cgi: "my" variable %co masks earlier declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi line 1615.

There might be a patch offset of few lines because I deleted my local gitweb settings from the patch.

Signed-off-by: Jochen Roemling <jochen@roemling.net>

--- /cgi-bin/gitweb.cgi.2 2005-05-29 17:23:10.000000000 +0200 +++ cgi-bin/gitweb.cgi 2005-05-30 21:26:44.000000000 +0200

Show changes to diff +1 −3

@@ -1616,7 +1618,7 @@
  		}
  		my @commit_lines = split "\n", $commit_text;
  		my $commit = shift @commit_lines;
-		my %co = git_read_commit($commit, \@commit_lines);
+		%co = git_read_commit($commit, \@commit_lines);
  		if (!%co) {
  			next;
  		}
@@ -1653,7 +1655,6 @@
  	$/ = "\n";
  	open $fd, "-|", "$gitbin/git-rev-list $hash | $gitbin/git-diff-tree 
-r --stdin -S$searchtext";
  	$alternate = 0;
-	my %co;
  	my @files;
  	while (my $line = <$fd>) {
  		if (%co && $line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40}) 
([0-9a-fA-F]{40}) (.)\t(.*)$/) {

Kay Sievers· May 31, 2005, 09:48 UTC · re: Jochen Roemling · lore

Re: [gitweb PATCH] Kill warnings in Webserver Error Log

On Mon, May 30, 2005 at 09:34:44PM +0200, Jochen Roemling wrote:

Show 11 quoted lines

> The following patch kills two warnings in the Web Server Error Log:
> 
> [Mon May 30 21:24:15 2005] gitweb.cgi: "my" variable %co masks earlier 
> declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi 
> line 1658.
> [Mon May 30 21:25:46 2005] gitweb.cgi: "my" variable %co masks earlier 
> declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi 
> line 1615.
> 
> There might be a patch offset of few lines because I deleted my local 
> gitweb settings from the patch.

Dou you get the version from:
  ftp://ehlo.org/gitweb.cgi

It seems already fixed.

Thanks, Kay

patchKill warnings in Webserver Error Log