{"thread":{"id":"769","subject":"[gitweb PATCH] Kill warnings in Webserver Error Log","startedAt":"2005-05-30T19:34:44Z","lastAt":"2005-05-31T09:48:38Z","messageCount":2,"participants":["Jochen Roemling","Kay Sievers"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"4264","messageId":"429B6AD4.9010107@roemling.net","threadId":"769","inReplyTo":null,"subject":"[gitweb PATCH] Kill warnings in Webserver Error Log","fromName":"Jochen Roemling","fromEmail":"jochen@roemling.net","sentAt":"2005-05-30T19:34:44Z","receivedAt":"2005-05-30T19:34:44Z","isPatch":true,"sender":{"key":"jochen@roemling.net","avatar":"https://gravatar.com/avatar/fd825445a548573b8483227eea8a12d7d3e474693d15bc2b77d9ee7df8870948?d=mp&s=160"},"body":"The following patch kills two warnings in the Web Server Error Log:\n\n[Mon May 30 21:24:15 2005] gitweb.cgi: \"my\" variable %co masks earlier \ndeclaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi \nline 1658.\n[Mon May 30 21:25:46 2005] gitweb.cgi: \"my\" variable %co masks earlier \ndeclaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi \nline 1615.\n\nThere might be a patch offset of few lines because I deleted my local \ngitweb settings from the patch.\n\nSigned-off-by: Jochen Roemling <jochen@roemling.net>\n\n--- /cgi-bin/gitweb.cgi.2\t2005-05-29 17:23:10.000000000 +0200\n+++ cgi-bin/gitweb.cgi\t2005-05-30 21:26:44.000000000 +0200\n@@ -1616,7 +1618,7 @@\n  \t\t}\n  \t\tmy @commit_lines = split \"\\n\", $commit_text;\n  \t\tmy $commit = shift @commit_lines;\n-\t\tmy %co = git_read_commit($commit, \\@commit_lines);\n+\t\t%co = git_read_commit($commit, \\@commit_lines);\n  \t\tif (!%co) {\n  \t\t\tnext;\n  \t\t}\n@@ -1653,7 +1655,6 @@\n  \t$/ = \"\\n\";\n  \topen $fd, \"-|\", \"$gitbin/git-rev-list $hash | $gitbin/git-diff-tree \n-r --stdin -S$searchtext\";\n  \t$alternate = 0;\n-\tmy %co;\n  \tmy @files;\n  \twhile (my $line = <$fd>) {\n  \t\tif (%co && $line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40}) \n([0-9a-fA-F]{40}) (.)\\t(.*)$/) {\n"},{"id":"4293","messageId":"20050531094838.GA22853@vrfy.org","threadId":"769","inReplyTo":"429B6AD4.9010107@roemling.net","subject":"Re: [gitweb PATCH] Kill warnings in Webserver Error Log","fromName":"Kay Sievers","fromEmail":"kay.sievers@vrfy.org","sentAt":"2005-05-31T09:48:38Z","receivedAt":"2005-05-31T09:48:38Z","isPatch":true,"sender":{"key":"kay.sievers@vrfy.org","avatar":null},"body":"On Mon, May 30, 2005 at 09:34:44PM +0200, Jochen Roemling wrote:\n> The following patch kills two warnings in the Web Server Error Log:\n> \n> [Mon May 30 21:24:15 2005] gitweb.cgi: \"my\" variable %co masks earlier \n> declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi \n> line 1658.\n> [Mon May 30 21:25:46 2005] gitweb.cgi: \"my\" variable %co masks earlier \n> declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi \n> line 1615.\n> \n> There might be a patch offset of few lines because I deleted my local \n> gitweb settings from the patch.\n\nDou you get the version from:\n  ftp://ehlo.org/gitweb.cgi\n\nIt seems already fixed.\n\nThanks,\nKay\n"}]}