[PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec

Brian Gernhardt· Mar 29, 2007, 14:37 UTC · lore

We don't have a copy of subprocess.py anymore, so we removed that option from the Makefile. Let's not leave that cruft around the RPM spec file either. ---

Resend of earlier patch, this time on top of 'master' instead of a random patch from the list.

 git.spec.in |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Show changes to git.spec.in +2 −3

diff --git a/git.spec.in b/git.spec.in
index 46aee88..be6da58 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -85,13 +85,12 @@ Perl interface to Git
 %setup -q
 
 %build
-make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" WITH_OWN_SUBPROCESS_PY=YesPlease \
-     prefix=%{_prefix} all %{!?_without_docs: doc}
+make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" prefix=%{_prefix} \
+     all %{!?_without_docs: doc}
 
 %install
 rm -rf $RPM_BUILD_ROOT
 make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" DESTDIR=$RPM_BUILD_ROOT \
-     WITH_OWN_SUBPROCESS_PY=YesPlease \
      prefix=%{_prefix} mandir=%{_mandir} INSTALLDIRS=vendor \
      install %{!?_without_docs: install-doc}
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'

-- 
1.5.1.rc2.4.g442d

Junio C Hamano· Mar 29, 2007, 20:21 UTC · re: Brian Gernhardt · lore

Re: [PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec

Brian Gernhardt <benji@silverinsanity.com> writes:

Show 7 quoted lines

> We don't have a copy of subprocess.py anymore, so we removed that
> option from the Makefile.  Let's not leave that cruft around the RPM
> spec file either.
> ---
>
> Resend of earlier patch, this time on top of 'master' instead of a
> random patch from the list.

Queued as a post-1.5.1 item, in 'pu' already.

patchRemove unused WITH_OWN_SUBPROCESS_PY from RPM spec