# [PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec

2 messages from 2007-03-29 to 2007-03-29. Participants: Brian Gernhardt, Junio C Hamano.
Thread: https://gitlist.dev/t/7474

## Brian Gernhardt, 2007-03-29 14:37

Subject: [PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec
Message-ID: <20070329143703.GA17854@170.242.249.10.in-addr.arpa>
URL: https://gitlist.dev/e/20070329143703.GA17854%40170.242.249.10.in-addr.arpa

```
We don't have a copy of subprocess.py anymore, so we removed that
option from the Makefile.  Let's not leave that cruft around the RPM
spec file either.
---

Resend of earlier patch, this time on top of 'master' instead of a
random patch from the list.

 git.spec.in |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/git.spec.in b/git.spec.in
index 46aee88..be6da58 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -85,13 +85,12 @@ Perl interface to Git
 %setup -q
 
 %build
-make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" WITH_OWN_SUBPROCESS_PY=YesPlease \
-     prefix=%{_prefix} all %{!?_without_docs: doc}
+make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" prefix=%{_prefix} \
+     all %{!?_without_docs: doc}
 
 %install
 rm -rf $RPM_BUILD_ROOT
 make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" DESTDIR=$RPM_BUILD_ROOT \
-     WITH_OWN_SUBPROCESS_PY=YesPlease \
      prefix=%{_prefix} mandir=%{_mandir} INSTALLDIRS=vendor \
      install %{!?_without_docs: install-doc}
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-- 
1.5.1.rc2.4.g442d

```

## Junio C Hamano, 2007-03-29 20:21

Subject: Re: [PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec
Message-ID: <7vslbn3io7.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vslbn3io7.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20070329143703.GA17854@170.242.249.10.in-addr.arpa>

```
Brian Gernhardt <benji@silverinsanity.com> writes:

> We don't have a copy of subprocess.py anymore, so we removed that
> option from the Makefile.  Let's not leave that cruft around the RPM
> spec file either.
> ---
>
> Resend of earlier patch, this time on top of 'master' instead of a
> random patch from the list.

Queued as a post-1.5.1 item, in 'pu' already.

```