[PATCH] --pretty=format: fix broken %ct and %at interpolation

Jeff King· Mar 27, 2007, 23:26 UTC · lore

A pointer arithmetic error in fill_person caused random data from the commit object to be included with the timestamp, which looked something like:

    $ git-rev-list --pretty=format:%ct origin/next | head
    commit 98453bdb3db10db26099749bc4f2dc029bed9aa9
    1174977948 -0700

    Merge branch 'master' into next

    * master:
      Bisect: Use
    commit c0ce981f5ebfd02463ff697b2fca52c7a54b0625
    1174889646 -0700

Signed-off-by: Jeff King <peff@peff.net>
---
 commit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to commit.c +1 −1

diff --git a/commit.c b/commit.c
index 718e568..a92958c 100644
--- a/commit.c
+++ b/commit.c
@@ -760,7 +760,7 @@ static void fill_person(struct interp *table, const char *msg, int len)
 	if (msg + start == ep)
 		return;
 
-	table[5].value = xstrndup(msg + start, ep - msg + start);
+	table[5].value = xstrndup(msg + start, ep - (msg + start));
 
 	/* parse tz */
 	for (start = ep - msg + 1; start < len && isspace(msg[start]); start++)

-- 
1.5.1.rc2.618.g98453b

Johannes Schindelin· Mar 27, 2007, 23:42 UTC · re: Jeff King · lore

Re: [PATCH] --pretty=format: fix broken %ct and %at interpolation

Hi,

On Tue, 27 Mar 2007, Jeff King wrote:

> A pointer arithmetic error in fill_person caused random data
> from the commit object to be included with the timestamp,

Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

patch--pretty=format: fix broken %ct and %at interpolation