{"thread":{"id":"7440","subject":"[PATCH] --pretty=format: fix broken %ct and %at interpolation","startedAt":"2007-03-27T23:26:28Z","lastAt":"2007-03-27T23:42:49Z","messageCount":2,"participants":["Jeff King","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38199","messageId":"20070327232628.GA9981@coredump.intra.peff.net","threadId":"7440","inReplyTo":null,"subject":"[PATCH] --pretty=format: fix broken %ct and %at interpolation","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-03-27T23:26:28Z","receivedAt":"2007-03-27T23:26:28Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"A pointer arithmetic error in fill_person caused random data\nfrom the commit object to be included with the timestamp,\nwhich looked something like:\n\n    $ git-rev-list --pretty=format:%ct origin/next | head\n    commit 98453bdb3db10db26099749bc4f2dc029bed9aa9\n    1174977948 -0700\n\n    Merge branch 'master' into next\n\n    * master:\n      Bisect: Use\n    commit c0ce981f5ebfd02463ff697b2fca52c7a54b0625\n    1174889646 -0700\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n commit.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/commit.c b/commit.c\nindex 718e568..a92958c 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -760,7 +760,7 @@ static void fill_person(struct interp *table, const char *msg, int len)\n \tif (msg + start == ep)\n \t\treturn;\n \n-\ttable[5].value = xstrndup(msg + start, ep - msg + start);\n+\ttable[5].value = xstrndup(msg + start, ep - (msg + start));\n \n \t/* parse tz */\n \tfor (start = ep - msg + 1; start < len && isspace(msg[start]); start++)\n-- \n1.5.1.rc2.618.g98453b\n"},{"id":"38202","messageId":"Pine.LNX.4.63.0703280142230.4045@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7440","inReplyTo":"20070327232628.GA9981@coredump.intra.peff.net","subject":"Re: [PATCH] --pretty=format: fix broken %ct and %at interpolation","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-27T23:42:49Z","receivedAt":"2007-03-27T23:42:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 27 Mar 2007, Jeff King wrote:\n\n> A pointer arithmetic error in fill_person caused random data\n> from the commit object to be included with the timestamp,\n\nAcked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n"}]}