[patch] prefer "git COMMAND" over "git-COMMAND" in gitk

Brandon Casey· Mar 19, 2007, 23:00 UTC · lore

Preferring git _space_ COMMAND over git _dash_ COMMAND allows the user to have only git and gitk in their path. e.g. when git and gitk are symbolic links in a personal bin directory to the real git and gitk.

Perfect time to say Thanks for the great work.

-brandon

--- gitk.orig 2007-02-13 20:46:46.000000000 -0600 +++ gitk 2007-03-19 17:46:55.142030000 -0500

Show changes to diff +2 −2

@@ -1904,7 +1904,7 @@
      } else {
         set gdtargs [list "-S$highlight_files"]
      }
-    set cmd [concat | git-diff-tree -r -s --stdin $gdtargs]
+    set cmd [concat | git diff-tree -r -s --stdin $gdtargs]
      set filehighlight [open $cmd r+]
      fconfigure $filehighlight -blocking 0
      fileevent $filehighlight readable readfhighlight
@@ -1956,7 +1956,7 @@
      }
      if {[eof $filehighlight]} {
         # strange...
-       puts "oops, git-diff-tree died"
+       puts "oops, git diff-tree died"
         catch {close $filehighlight}
         unset filehighlight
      }

Paul Mackerras· Mar 21, 2007, 11:04 UTC · re: Brandon Casey · lore

Re: [patch] prefer "git COMMAND" over "git-COMMAND" in gitk

Brandon Casey writes:

> Preferring git _space_ COMMAND over git _dash_ COMMAND allows the
> user to have only git and gitk in their path. e.g. when git and gitk
> are symbolic links in a personal bin directory to the real git and gitk.

Thanks for the patch. It was whitespace-damaged but I fixed it up (this once) and applied it. Also, if you send any larger patches in future I'd like a Signed-off-by line with them (this one was trivial enough that I applied it without).

Paul.

patchprefer "git COMMAND" over "git-COMMAND" in gitk