# [patch] prefer "git COMMAND" over "git-COMMAND" in gitk 2 messages from 2007-03-19 to 2007-03-21. Participants: Brandon Casey, Paul Mackerras. Thread: https://gitlist.dev/t/7321 ## Brandon Casey, 2007-03-19 23:00 Subject: [patch] prefer "git COMMAND" over "git-COMMAND" in gitk Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0703191746150.5525%40torch.nrlssc.navy.mil ``` Preferring git _space_ COMMAND over git _dash_ COMMAND allows the user to have only git and gitk in their path. e.g. when git and gitk are symbolic links in a personal bin directory to the real git and gitk. Perfect time to say Thanks for the great work. -brandon --- gitk.orig 2007-02-13 20:46:46.000000000 -0600 +++ gitk 2007-03-19 17:46:55.142030000 -0500 @@ -1904,7 +1904,7 @@ } else { set gdtargs [list "-S$highlight_files"] } - set cmd [concat | git-diff-tree -r -s --stdin $gdtargs] + set cmd [concat | git diff-tree -r -s --stdin $gdtargs] set filehighlight [open $cmd r+] fconfigure $filehighlight -blocking 0 fileevent $filehighlight readable readfhighlight @@ -1956,7 +1956,7 @@ } if {[eof $filehighlight]} { # strange... - puts "oops, git-diff-tree died" + puts "oops, git diff-tree died" catch {close $filehighlight} unset filehighlight } ``` ## Paul Mackerras, 2007-03-21 11:04 Subject: Re: [patch] prefer "git COMMAND" over "git-COMMAND" in gitk Message-ID: <17921.4429.408665.577258@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/17921.4429.408665.577258%40cargo.ozlabs.ibm.com In-Reply-To: ``` Brandon Casey writes: > Preferring git _space_ COMMAND over git _dash_ COMMAND allows the > user to have only git and gitk in their path. e.g. when git and gitk > are symbolic links in a personal bin directory to the real git and gitk. Thanks for the patch. It was whitespace-damaged but I fixed it up (this once) and applied it. Also, if you send any larger patches in future I'd like a Signed-off-by line with them (this one was trivial enough that I applied it without). Paul. ```