threads / patch / 6911

patchInclude git-gui credits file in dist.

Subject: [PATCH] Include git-gui credits file in dist.

## tl;dr

2 messages between Feb 22, 2007 and Feb 22, 2007. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Shawn O. Pearce· Feb 22, 2007, 04:49 UTC · lore

The Makefile for the git-gui subproject will fail to execute if run outside of a git.git directory, such as when building from a .tar.gz or .tar.bz2. This is because it is looking for the credits file, which was created but omitted from the tarball by the toplevel Makefile.

---
 This has to go on `maint` before you create the release tarball
 for 1.5.0.2, otherwise 1.5.0.2 cannot be compiled outside of a
 git.git repository.
 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to Makefile +2 −1
diff --git a/Makefile b/Makefile
index 289decd..35be5e2 100644
--- a/Makefile
+++ b/Makefile
@@ -895,7 +895,8 @@ dist: git.spec git-archive
 	$(TAR) rf $(GIT_TARNAME).tar \
 		$(GIT_TARNAME)/git.spec \
 		$(GIT_TARNAME)/version \
-		$(GIT_TARNAME)/git-gui/version
+		$(GIT_TARNAME)/git-gui/version \
+		$(GIT_TARNAME)/git-gui/credits
 	@rm -rf $(GIT_TARNAME)
 	gzip -f -9 $(GIT_TARNAME).tar
 
-- 
1.5.0.61.ga0bf
Shawn O. Pearce· Feb 22, 2007, 04:56 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] Include git-gui credits file in dist.

"Shawn O. Pearce" <spearce@spearce.org> wrote:
Show 5 quoted lines
> The Makefile for the git-gui subproject will fail to execute if run
> outside of a git.git directory, such as when building from a .tar.gz
> or .tar.bz2.  This is because it is looking for the credits file,
> which was created but omitted from the tarball by the toplevel
> Makefile.
Obviously I forgot this little line, sorry:
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
-- 
Shawn.

← back to recent threads